Skip to content

storage: Snapshot the VM multiple times before exporting/importing#438

Open
last-genius wants to merge 3 commits into
masterfrom
asv/storage-export-snapshot
Open

storage: Snapshot the VM multiple times before exporting/importing#438
last-genius wants to merge 3 commits into
masterfrom
asv/storage-export-snapshot

Conversation

@last-genius
Copy link
Copy Markdown
Contributor

Adds a new with_snapshot parameter which, if enabled, snapshots the VM
twice before the export/import cycle.

This tests for the bug we are seeing now with QCOW2, where the full
chain of snapshots is not considered.

Leave holes in each snapshot by writing to independent sections to verify
all the snapshot's bitmaps are consulted.


This test passes with the current pre-build of xapi: xapi-26.1.3-1.6~fixsnapexport.6.xcpng8.3

@last-genius last-genius requested review from a team as code owners March 26, 2026 08:45
Copy link
Copy Markdown
Member

@glehmann glehmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
It will conflict with #437

Adds a new with_snapshot parameter which, if enabled, snapshots the VM
twice before the export/import cycle.

This tests for the bug we are seeing now with QCOW2, where the full
chain of snapshots is not considered.

Leave holes in each snapshot by writing to independent sections to verify
all the snapshot's bitmaps are consulted.

Signed-off-by: Andrii Sultanov <andriy.sultanov@vates.tech>
…ameter

Signed-off-by: Andrii Sultanov <andriy.sultanov@vates.tech>
@last-genius last-genius force-pushed the asv/storage-export-snapshot branch from 9e50715 to 48afd3c Compare April 20, 2026 14:25
Signed-off-by: Andrii Sultanov <andriy.sultanov@vates.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants