Skip to content

Tools/update - add nested mark in inventory#455

Closed
olivierh-pro wants to merge 1 commit into
masterfrom
ohu/update-tools/snapshot-0
Closed

Tools/update - add nested mark in inventory#455
olivierh-pro wants to merge 1 commit into
masterfrom
ohu/update-tools/snapshot-0

Conversation

@olivierh-pro
Copy link
Copy Markdown
Contributor

@olivierh-pro olivierh-pro commented Apr 1, 2026

Add nested = true|false in inventory to prepare snapshot creation.

This new "nested" mark in inventory allow me to differentiate physical hosts from nested hosts to perform snapshot creation accordingly.

@olivierh-pro olivierh-pro force-pushed the ohu/update-tools/snapshot-0 branch from 4f06a71 to 563cb30 Compare April 2, 2026 09:55
@olivierh-pro olivierh-pro changed the base branch from master to ohu/xcpng-update/003 April 2, 2026 10:00
@olivierh-pro olivierh-pro force-pushed the ohu/update-tools/snapshot-0 branch from 563cb30 to f81a0cc Compare April 2, 2026 13:02
@olivierh-pro olivierh-pro force-pushed the ohu/xcpng-update/003 branch from d090120 to 93d0316 Compare April 2, 2026 13:03
@olivierh-pro olivierh-pro force-pushed the ohu/update-tools/snapshot-0 branch from 1de4450 to f81a0cc Compare April 3, 2026 14:52
@olivierh-pro olivierh-pro force-pushed the ohu/xcpng-update/003 branch from 93d0316 to bdefa60 Compare April 8, 2026 07:25
@olivierh-pro olivierh-pro force-pushed the ohu/update-tools/snapshot-0 branch from f81a0cc to dc08c6d Compare April 8, 2026 07:25
@olivierh-pro olivierh-pro force-pushed the ohu/xcpng-update/003 branch from bdefa60 to d41e251 Compare April 8, 2026 09:42
@olivierh-pro olivierh-pro force-pushed the ohu/update-tools/snapshot-0 branch from dc08c6d to 0678e63 Compare April 8, 2026 09:43
@olivierh-pro olivierh-pro force-pushed the ohu/xcpng-update/003 branch from d41e251 to d8b39a3 Compare April 8, 2026 14:56
@olivierh-pro olivierh-pro force-pushed the ohu/update-tools/snapshot-0 branch from 0678e63 to f0f6f3f Compare April 8, 2026 14:56
@olivierh-pro olivierh-pro force-pushed the ohu/xcpng-update/003 branch from d8b39a3 to d834a8b Compare April 9, 2026 07:32
@olivierh-pro olivierh-pro force-pushed the ohu/update-tools/snapshot-0 branch from f0f6f3f to 3116cc9 Compare April 9, 2026 07:32
@olivierh-pro olivierh-pro force-pushed the ohu/xcpng-update/003 branch from d834a8b to 5f39a9d Compare April 20, 2026 09:35
@olivierh-pro olivierh-pro force-pushed the ohu/update-tools/snapshot-0 branch from 3116cc9 to f626f49 Compare April 20, 2026 09:35
Comment thread lib/tools/inventory.py Outdated
@olivierh-pro olivierh-pro force-pushed the ohu/xcpng-update/003 branch from 5f39a9d to a6d2149 Compare April 21, 2026 13:08
@olivierh-pro olivierh-pro force-pushed the ohu/update-tools/snapshot-0 branch from f626f49 to 03bab98 Compare April 21, 2026 14:11
@olivierh-pro olivierh-pro force-pushed the ohu/xcpng-update/003 branch from a6d2149 to f38689a Compare April 21, 2026 14:12
@olivierh-pro olivierh-pro force-pushed the ohu/update-tools/snapshot-0 branch from 03bab98 to 44b42fd Compare April 21, 2026 14:12
Base automatically changed from ohu/xcpng-update/003 to master April 21, 2026 14:13
@olivierh-pro olivierh-pro force-pushed the ohu/update-tools/snapshot-0 branch from 44b42fd to fb99ddd Compare April 21, 2026 14:15
@olivierh-pro olivierh-pro marked this pull request as ready for review April 21, 2026 14:23
@olivierh-pro olivierh-pro requested a review from a team as a code owner April 21, 2026 14:23
@olivierh-pro olivierh-pro force-pushed the ohu/update-tools/snapshot-0 branch 2 times, most recently from be11d64 to 863fffb Compare April 21, 2026 14:39
Signed-off-by: Olivier Hoareau <olivier.hoareau@vates.tech>
@olivierh-pro olivierh-pro force-pushed the ohu/update-tools/snapshot-0 branch from 863fffb to 9fbb345 Compare April 21, 2026 14:43
@olivierh-pro olivierh-pro requested a review from rzr April 21, 2026 14:48
Comment thread lib/tools/inventory.py
host = {
host: dict[str, list[str] | bool] = {
"nested": nested or False,
"enablerepos": enablerepos or [],
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would sort alphabatically (e before n)

Comment thread README.md
# my_inventory.toml

[all]
nested = true
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

@rzr rzr requested a review from a team April 23, 2026 07:46
@glehmann
Copy link
Copy Markdown
Member

Add nested = true|false in inventory to prepare snapshot creation.

This new "nested" mark in inventory allow me to differentiate physical hosts from nested hosts to perform snapshot creation accordingly.

But we'll need more info than just nested to create the snapshot, so maybe it would be simpler to just define the host it's on?

IMO, this PR on its own is too small to understand where this is going. Maybe include an actual feature in the PR, or link it to another PR that implements the feature?

@olivierh-pro
Copy link
Copy Markdown
Contributor Author

Discussed with @glehmann (related to this). I will merge this work with another existing PR (#468).

I close this PR

@olivierh-pro olivierh-pro deleted the ohu/update-tools/snapshot-0 branch April 24, 2026 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants