Robustify LINSTOR test_diskless_kept test#494
Merged
Conversation
gduperrey
approved these changes
Apr 22, 2026
Member
gduperrey
left a comment
gduperrey
left a comment
There was a problem hiding this comment.
We had the CI ran on this branch, so ok on the CI side :)
Nambrok
requested changes
Apr 22, 2026
Wescoeur
force-pushed
the
ran-skip-linstor-replica-diskless
branch
from
0e75881 to
b5bf74f
Compare
Nambrok
approved these changes
Apr 22, 2026
rzr
reviewed
Apr 23, 2026
| CACHE_IMPORTED_VM = False | ||
|
|
||
| # Default LINSTOR redundancy configuration for creating SRs. | ||
| LINSTOR_REDUNDANCY = 2 |
Contributor
There was a problem hiding this comment.
I see that value is decreased from 3 to 2 ? may this be explained in commit message ?
Member
Author
There was a problem hiding this comment.
Not totally true, this value is not decreased from 3 to 2. Before this change the number of hosts was used as LINSTOR redundancy with a maximum value of 3. But yes I agree, not a bad idea to add this info in the first commit.
Before this change the number of hosts was used as LINSTOR redundancy with a maximum value of 3. We can now explicitly choose 1, 2 or 3. Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.tech>
Without this fix, the `assert diskless` line is triggered and the test fails. Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.tech>
Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.tech>
Wescoeur
force-pushed
the
ran-skip-linstor-replica-diskless
branch
from
b5bf74f to
a1a6f99
Compare
glehmann
reviewed
Apr 23, 2026
stormi
force-pushed
the
ran-skip-linstor-replica-diskless
branch
2 times, most recently
from
0a10055 to
b2f7a8a
Compare
Co-authored-by: Gaëtan Lehmann <glehmann@users.noreply.github.com> Signed-off-by: Samuel Verschelde <stormi-xcp@ylix.fr>
stormi
force-pushed
the
ran-skip-linstor-replica-diskless
branch
from
b2f7a8a to
c8a7875
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LINSTOR_REDUNDANCYto configure LINSTOR replication count.