Avoid destroying/unloading the resources before entering the debugger#503
Merged
Conversation
to ease the resource management in some complex tests. See the defer docstring in conftest.py for more details. Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>
semarie
approved these changes
Apr 28, 2026
Contributor
semarie
left a comment
semarie
left a comment
There was a problem hiding this comment.
LGTM
it will be a good improvement for readability and debugging, thanks.
psafont
approved these changes
Apr 28, 2026
Contributor
psafont
left a comment
psafont
left a comment
There was a problem hiding this comment.
Nice change, it reduces indentation while managing resources, similar to OCaml's pattern of using let@ resource = with_resource params in ...
olivierh-pro
approved these changes
Apr 28, 2026
dinhngtu
requested changes
Apr 28, 2026
Member
dinhngtu
left a comment
dinhngtu
left a comment
There was a problem hiding this comment.
I wonder if there are fixtures that can be trivially replaced by defer, and will that net us any benefit in terms of code cleanliness?
Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>
glehmann
force-pushed
the
gln/tests-add-defer-fixture-yrnw
branch
from
ee0f37d to
09c4d6e
Compare
dinhngtu
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same as #436, but for tests not in storage/