Skip to content

XCPNG-3592: network: VLAN filtering tests - #652

Merged
semarie merged 1 commit into
masterfrom
srt/vlan-filtering
Aug 24, 2026
Merged

XCPNG-3592: network: VLAN filtering tests#652
semarie merged 1 commit into
masterfrom
srt/vlan-filtering

Conversation

@semarie

@semarie semarie commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

add basic tests on VLAN filtering.

  • configure a trunk over internal network to avoid CI conflicts
  • start 1 VM using the trunk and monitoring packets
  • start 1 VM sending packets on specific VLAN
  • ensure trunks parameter (on first VM) properly let's pass or filter the VLAN

@semarie semarie self-assigned this Aug 4, 2026
@semarie

semarie commented Aug 4, 2026

Copy link
Copy Markdown
Contributor Author

Keep the PR as draft while xapi package with VLAN filtering isn't published

Base automatically changed from srt/empty_network to master August 5, 2026 15:40
@semarie
semarie force-pushed the srt/vlan-filtering branch from 1dc18d8 to fda173e Compare August 5, 2026 15:41
@bleader

bleader commented Aug 6, 2026

Copy link
Copy Markdown

The test file is named test_trunks, tests themselves are test_passing and test_filtered, it is not super obvious that we are testing filtering beside the test_filtered, I would like to make it more obvious. Either we dedicate the file itself to filtering and rename it, or we want to add mapping or more generic trunking tests in the future to it, and in that case the tests name can be changed. What do you think?

@semarie

semarie commented Aug 6, 2026

Copy link
Copy Markdown
Contributor Author

naming is complex 😄

the test file is named test_trunks because it is about testing the trunks attribute on VIF (used for VLAN filtering), named itself from the trunks attribute in OVS (which is used to configure which VLAN are allowed on the VIF).

But I agree it could be misleading. I will rename the file.

@semarie
semarie force-pushed the srt/vlan-filtering branch from fda173e to a4517ae Compare August 6, 2026 08:44
@semarie

semarie commented Aug 6, 2026

Copy link
Copy Markdown
Contributor Author

Last push:

  • rename test_trunks.py to test_vlan_filtering.py
  • add a Requirements comment at top of file

@semarie
semarie marked this pull request as ready for review August 19, 2026 06:35
@semarie
semarie requested review from a team as code owners August 19, 2026 06:35
@semarie

semarie commented Aug 19, 2026

Copy link
Copy Markdown
Contributor Author

Making ready for review as the feature has been published in 8.3-20260818

Comment thread tests/network/test_vlan_filtering.py Outdated
Comment thread tests/network/test_vlan_filtering.py Outdated
add basic tests on VLAN filtering.

- configure a trunk over internal network to avoid CI conflicts
- start 1 VM using the trunk and monitoring packets
- start 1 VM sending packets on specific VLAN
- ensure `trunks` parameter (on first VM) properly let's pass or filter the VLAN

Signed-off-by: Sebastien Rodot <sebastien.rodot@vates.tech>
@semarie
semarie force-pushed the srt/vlan-filtering branch from a4517ae to bf2df7b Compare August 19, 2026 15:10
@semarie

semarie commented Aug 19, 2026

Copy link
Copy Markdown
Contributor Author

Last push:

  • rebase on top of master
  • incoporate feedback from @glehmann

@semarie
semarie merged commit a8d96b6 into master Aug 24, 2026
12 checks passed
@semarie
semarie deleted the srt/vlan-filtering branch August 24, 2026 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants