quicktest: split tests into SR specific and common ones - #665
Conversation
|
I'm currently testing it on my lab (that is why it is a draft). |
de11940 to
ff851c8
Compare
|
I just pushed code for compatibility between versions of quicktest to show what I meant. |
|
And there is a PR to add |
ff851c8 to
8ce9c22
Compare
|
xapi-project/xen-api#7227 has been merged. However, after review, a more generic mechanism was introduced in Quicktest that allows us to use tags. So to run tests that depend on I have updated the PR accordingly. Note that this is currently only merged upstream (not in 8.3). However, the current patch selects specific tests using |
|
@gthvn1 It's still a draft, and re-view was not re-requested. Is that on purpose? |
|
@stormi , yes I was waiting a week to be sure that it passes the Citrix CI upstream and it is not reverted before asking new reviews. |
|
PRs are merged in master and lcm. It will be in our 8.3 when we will rebase 26.1.22. So let's review it. |
glehmann
left a comment
glehmann
left a comment
There was a problem hiding this comment.
A comment or commit description about which XCP-ng or xapi version is supposed to go to which scoping path would probably be useful in the future, when we'll stop supporting the older versions, and we'll want to remove the scoping mechanism
| NO_PARAM = enum.auto() | ||
|
|
||
| @functools.lru_cache(maxsize=None) | ||
| def _quicktest_scoping(hostname_or_ip: str) -> QuicktestScoping: |
There was a problem hiding this comment.
nit: the host can be passed directly as a parameter and used as host.ssh(…)
Wescoeur
left a comment
Wescoeur
left a comment
There was a problem hiding this comment.
Just regarding commit title: QT is redundant with quicktest. Also is it a common acronym? Otherwise I have the impression that we are talking about qt5 or qt6 when reading this word. 😅
Regarding the code: nothing to add.
|
I will change the QT. It is an acronym but yes it depends on your background :) |
8ce9c22 to
e0b45a0
Compare
gthvn1
changed the title
Currently we are calling quicktest for all SRs. The problem is that it takes long time to run and some tests are not related to the type of the SR. This patch creates one new test that runs the common suites one, and we only run SR specific tests per SR. A new option has been added to Quicktest (-list-tags/-with-tags) that allows to select tests. _quicktest_scoping() detects which the target host supports and picks accordingly. This option should be available in XAPI 26.18.0 for master and 26.1.23 for lcm. Signed-off-by: Guillaume Thouvenin <guillaume.thouvenin@vates.tech>
e0b45a0 to
1699f2b
Compare
I have updated the commit message with both versions, XAPI master and lcm. |
5 participants
Currently we are calling quicktest for all SRs. The problem is that it takes long time to run and some tests are not related to the type of the SR. This patch creates one new test that runs the common suites one, and we only run SR specific tests per SR.