update tool: sync xcpng-users.repo from koji before update - #685
Merged
Conversation
gduperrey
approved these changes
Aug 27, 2026
rzr
reviewed
Aug 31, 2026
| ) | ||
| repo_file = '/etc/yum.repos.d/xcpng-users.repo' | ||
| logger.info(f"[{host}] Downloading {repo_url} to {repo_file}") | ||
| host.ssh(f"curl -fsS -o {repo_file} '{repo_url}'") |
Contributor
There was a problem hiding this comment.
Suggested change
| host.ssh(f"curl -fsS -o {repo_file} '{repo_url}'") | |
| host.ssh(f"yum-config-manager --add-repo '{repo_url}'") |
This is the yum way of doing it, unsure about doing it twice.
Member
Author
There was a problem hiding this comment.
yum-config-manager is not available (currently) on xcp-ng 9, so I think it's better to keep the curl version for now.
Download the koji xcpng-users.repo file on each host before running the update, to keep repository definitions in sync with koji. The URL is built from the host version. Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>
glehmann
force-pushed
the
gln/sync-xcpng-users-repo-xrtw
branch
from
September 2, 2026 12:50
ba9e93e to
e276200
Compare
olivierh-pro
approved these changes
Sep 3, 2026
rzr
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Download the koji xcpng-users.repo file on each host before running the
update, to keep repository definitions in sync with koji. The URL is built
from the host version.
Signed-off-by: Gaëtan Lehmann gaetan.lehmann@vates.tech
This PR is part of a stack containing 2 PRs:
master