Add post-install jobs - #688
Conversation
Signed-off-by: Samuel Verschelde <stormi-xcp@ylix.fr>
Signed-off-by: Samuel Verschelde <stormi-xcp@ylix.fr>
Signed-off-by: Samuel Verschelde <stormi-xcp@ylix.fr>
Signed-off-by: Samuel Verschelde <stormi-xcp@ylix.fr>
More specifically it does not include cross-pool migration tests. Signed-off-by: Vincent Michel <vincent.michel@vates.tech>
semarie
left a comment
semarie
left a comment
There was a problem hiding this comment.
Some commits might be squashed (on 5 commits, 2 commits are fixes for previous commits), but it isn't blocking from my point of view even if not ideal.
| }, | ||
| "paths": [ | ||
| "tests/xapi/tls_verification", | ||
| # because we want to test a pool join |
There was a problem hiding this comment.
| # because we want to test a pool join | |
| # because we want to test joining a pool. |
rzr
left a comment
rzr
left a comment
There was a problem hiding this comment.
About: Question: should tests/migration/test_cross_pool_migration.py::test_cross_pool_migration be included in a postinstall job as well?
I would tend to say, let's align to what has been done so far (manually?)
Anyway this can be done in later PR
Good point, I'll squash them before merging (I kept the orignal commits since it wasn't my branch to begin with). Speaking of which, I'm adding @stormi to the reviewers since he created this branch. |
5 participants
See XCPNG-3678
Three post-install jobs are added:
postinstallpostinstall-intrapool-migratepostinstall-with-tlsNote that
tests/migration/test_cross_pool_migration.py::test_cross_pool_migrationis not included in any of those three jobs.Question: should
tests/migration/test_cross_pool_migration.py::test_cross_pool_migrationbe included in apostinstalljob as well?