Repository navigation
Add a script to copy a branch to another branch in all our rpm repositories - #790
Merged
Merged
Conversation
glehmann
changed the title
glehmann
force-pushed
the
gln/add-rpm-copy-script-zlnu
branch
2 times, most recently
from
March 12, 2026 10:05
bf07a39 to
ecdb33f
Compare
Member
|
@glehmann If still useful let's ask the team for review. |
olivierh-pro
approved these changes
Aug 4, 2026
olivierh-pro
left a comment
olivierh-pro
left a comment
There was a problem hiding this comment.
LGTM! I would have wrapped it in a :
if __name__ == "__main__":
main()
vxgmichel
approved these changes
Aug 6, 2026
Contributor
There was a problem hiding this comment.
LGTM 👍 Just a couple of stylistic suggestions, feel free to ignore if they don't feel like an improvement.
Also I agree with @olivierh-pro about the use of if __name__ == "__main__":, for the reason I formulated here:
Some tools might try to import modules as part of their discovery process, and it's hard to know exactly which ones are going to run in this repository (considering that each developer might use different tools).
…tories Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>
Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>
glehmann
force-pushed
the
gln/add-rpm-copy-script-zlnu
branch
from
August 14, 2026 09:48
ecdb33f to
a19a828
Compare
vxgmichel
approved these changes
Aug 14, 2026
vxgmichel
left a comment
vxgmichel
left a comment
Contributor
There was a problem hiding this comment.
All my comments have been addressed, re-approving for good measure 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And also move the PR destination branch matching the old branch to the new branch