Repository navigation
[pkg_in_pipe] Try all the koji tagged builds in order until we find a source - #847
Merged
Merged
Conversation
… source It might happen that the previous tag build for a package does not have its source field filled in with the corresponding git commit (this typically happens for security updates that did not go through the standard release procedure). By trying again with the build before it until we find a source, we limit the amount of PRs and Plane cards that will be included in the reports (if no source is provided by `find_previous_build_commit`, all the PRs and cards are listed). Signed-off-by: Vincent Michel <vincent.michel@vates.tech>
vxgmichel
force-pushed
the
vml/fix-missing-source-in-koji-build
branch
from
September 18, 2026 11:04
c4168d4 to
13e4a02
Compare
glehmann
reviewed
Sep 18, 2026
glehmann
left a comment
glehmann
left a comment
Member
There was a problem hiding this comment.
I'd rather avoid the json format, which we too often get wrong when adding an element, because we can't have a comma , on the last element of the list.
Could you change it for toml?
It might happen that the previous tag build for a package does not have its source field filled in with the corresponding git commit (this typically happens for security updates that did not go through the standard release procedure). In order to avoid reporting extra PRs and plane cards, those missing sources can now be listed in the `missing_sources.toml` dictionary. Signed-off-by: Vincent Michel <vincent.michel@vates.tech>
vxgmichel
force-pushed
the
vml/fix-missing-source-in-koji-build
branch
from
September 18, 2026 12:13
13e4a02 to
22e1dec
Compare
Contributor
Author
Sure, done here: 22e1dec |
glehmann
approved these changes
Sep 18, 2026
rzr
approved these changes
Sep 21, 2026
bryanunitek
pushed a commit
to bryanunitek/UniCORE.XCP
that referenced
this pull request
Sep 23, 2026
This change was missing from the following PR: xcp-ng/xcp#847 Signed-off-by: Vincent Michel <vincent.michel@vates.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It might happen that the previous tag build for a package does not have its source field filled in with the corresponding git commit (this typically happens for security updates that did not go through the standard release procedure). By trying again with the build before it until we find a source, we limit the amount of PRs and Plane cards that will be included in the reports (if no source is provided by
find_previous_build_commit, all the PRs and cards are listed).In order to avoid reporting extra PRs and plane cards, those missing sources can also now be listed in the
missing_sources.jsondictionary.