Skip to content

Small adjustments and bug fixes#13

Merged
konstntokas merged 6 commits into
mainfrom
konstntokas-xxx-small_adjustments
Oct 20, 2025
Merged

Small adjustments and bug fixes#13
konstntokas merged 6 commits into
mainfrom
konstntokas-xxx-small_adjustments

Conversation

@konstntokas

@konstntokas konstntokas commented Oct 15, 2025

Copy link
Copy Markdown
Collaborator
  • Enhanced the function bbox_overlap so that it can handle bounding boxed crossing
    the antimeridian
  • Added new class method GridMapping.regular_from_bbox, which allows creating a
    regular grid mapping directly from a bounding box, spatial resolution, and CRS.
  • Bug fix: fixed grid mapping creation for irregular grids with decreasing longitude
    along axis 1.

Checklist:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/
  • Changes documented in CHANGES.md
  • CI checks pass
  • Test coverage remains or increases (target 100%)

@konstntokas konstntokas changed the title Konstntokas xxx small adjustments Small adjustments and bug fixes Oct 15, 2025
@konstntokas
konstntokas requested a review from b-yogesh October 15, 2025 11:28
@codecov

codecov Bot commented Oct 17, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.45455% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 98.73%. Comparing base (0d8ae5c) to head (5f3e09b).
⚠️ Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
xcube_resampling/gridmapping/coords.py 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #13      +/-   ##
==========================================
- Coverage   98.81%   98.73%   -0.08%     
==========================================
  Files          21       21              
  Lines        2021     2054      +33     
==========================================
+ Hits         1997     2028      +31     
- Misses         24       26       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@b-yogesh b-yogesh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please see the suggestion and merge it. Thanks

Comment thread CHANGES.md Outdated
@@ -1,3 +1,17 @@
## Changes in 0.2.0 (under development)

- Enhanced the function `bbox_overlap` so that it can handle bounding boxed crossing

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Enhanced the function `bbox_overlap` so that it can handle bounding boxed crossing
- Enhanced the function `bbox_overlap` so that it can handle bounding boxes crossing

@konstntokas
konstntokas merged commit 95e8199 into main Oct 20, 2025
1 of 3 checks passed
@konstntokas
konstntokas deleted the konstntokas-xxx-small_adjustments branch October 20, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants