Skip to content

Make gridmapping creation faster for 2d coordinates#19

Merged
konstntokas merged 7 commits into
mainfrom
konstntokas-xxx-make_gridmapping_creation_faster
Jan 8, 2026
Merged

Make gridmapping creation faster for 2d coordinates#19
konstntokas merged 7 commits into
mainfrom
konstntokas-xxx-make_gridmapping_creation_faster

Conversation

@konstntokas

@konstntokas konstntokas commented Jan 6, 2026

Copy link
Copy Markdown
Collaborator
  • Improved performance when creating GridMapping from 2D coordinates.
    Parameter estimation now uses only corner points instead of the full set of
    coordinates, significantly reducing runtime for large datasets.

xcube-resampling v0.2.3 (previous release)

xcube-resampling v0.2.3 output

xcube-resampling v0.2.4.dev0 (this PR)

Includes the performance improvements introduced in this PR.

xcube-resampling v0.2.4.dev0 output

Note that the previous release is identical with the implementation in xcube.
new_version.ipynb
old_version.ipynb
xcube_version.ipynb

Note as a test dataset, a Senintle-3 OLCI Level-1 EOPF Zarr sample is taken from https://stac.browser.user.eopf.eodc.eu/collections/sentinel-3-olci-l1-efr

Checklist:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/
  • Changes documented in CHANGES.md
  • CI checks pass
  • Test coverage remains or increases (target 100%)

@konstntokas
konstntokas marked this pull request as draft January 6, 2026 08:12
@codecov

codecov Bot commented Jan 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.85%. Comparing base (dde72ce) to head (4930532).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #19      +/-   ##
==========================================
+ Coverage   98.81%   98.85%   +0.04%     
==========================================
  Files          22       22              
  Lines        2189     2182       -7     
==========================================
- Hits         2163     2157       -6     
+ Misses         26       25       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@konstntokas
konstntokas marked this pull request as ready for review January 7, 2026 09:50
@konstntokas
konstntokas requested a review from b-yogesh January 7, 2026 09:50

@b-yogesh b-yogesh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please consider answering my questions. They are just for me to understand this algorithm better. We can a short call as well.

Comment thread xcube_resampling/gridmapping/coords.py
Comment thread xcube_resampling/gridmapping/coords.py
Comment thread xcube_resampling/gridmapping/coords.py
Comment thread xcube_resampling/gridmapping/coords.py
Comment thread xcube_resampling/rectify.py
@konstntokas
konstntokas merged commit c429669 into main Jan 8, 2026
3 checks passed
@konstntokas
konstntokas deleted the konstntokas-xxx-make_gridmapping_creation_faster branch January 8, 2026 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants