Make gridmapping creation faster for 2d coordinates#19
Merged
konstntokas merged 7 commits intoJan 8, 2026
Conversation
konstntokas
marked this pull request as draft
January 6, 2026 08:12
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #19 +/- ##
==========================================
+ Coverage 98.81% 98.85% +0.04%
==========================================
Files 22 22
Lines 2189 2182 -7
==========================================
- Hits 2163 2157 -6
+ Misses 26 25 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
konstntokas
marked this pull request as ready for review
January 7, 2026 09:50
b-yogesh
reviewed
Jan 8, 2026
b-yogesh
left a comment
Member
There was a problem hiding this comment.
LGTM, but please consider answering my questions. They are just for me to understand this algorithm better. We can a short call as well.
b-yogesh
approved these changes
Jan 8, 2026
konstntokas
deleted the
konstntokas-xxx-make_gridmapping_creation_faster
branch
January 8, 2026 16:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GridMappingfrom 2D coordinates.Parameter estimation now uses only corner points instead of the full set of
coordinates, significantly reducing runtime for large datasets.
xcube-resampling v0.2.3 (previous release)
xcube-resampling v0.2.4.dev0 (this PR)
Includes the performance improvements introduced in this PR.
Note that the previous release is identical with the implementation in xcube.
new_version.ipynb
old_version.ipynb
xcube_version.ipynb
Checklist:
Add docstrings and API docs for any new/modified user-facing classes and functionsNew/modified features documented indocs/CHANGES.md