Add support for multiple non-spatial dimensions#612
Open
clarasb wants to merge 28 commits into
Open
Conversation
… depth into time-series and statistics features
…mation intervall only in dimensionAnimationInterval
… dataset or variable
7 tasks
freds-dev
approved these changes
Jul 13, 2026
freds-dev
left a comment
freds-dev
left a comment
There was a problem hiding this comment.
Tested functionality. Worked fine.
freds-dev
self-requested a review
July 13, 2026 14:02
freds-dev
approved these changes
Jul 14, 2026
freds-dev
left a comment
freds-dev
left a comment
There was a problem hiding this comment.
LGTM. Just 2 minor things that might be worth looking at.
Comment on lines
+72
to
+75
| useEffect(() => { | ||
| playOrNot(); | ||
| return uninstallTimer; | ||
| }); |
There was a problem hiding this comment.
Can we add a dependency array here? Right now this runs after every render
Collaborator
Author
There was a problem hiding this comment.
Yes, but I suggest to do this in a separate PR, after this one is merged.
|
|
||
| useEffect(() => { | ||
| setSelectedDimensionValue_( | ||
| selectedDimensionValue || |
There was a problem hiding this comment.
Can 0 be a valid value here? If so, can we use ?? instead of ||?
Collaborator
Author
There was a problem hiding this comment.
Yes, sure. Thanks for pointing this out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add support for handling multiple non-spatial dataset dimensions (e.g. time, depth).
Changes
number)Testing
Mode 1
Mode 2
Closes #239.
Relevant for #608, however dimensions of type
stringare not supported yet.Related changes in xcube: xcube-dev/xcube#1234