Skip to content

Fix cells popup 'delete' string config resolving to global delete command - #1339

Closed
SergioChan wants to merge 3 commits into
xdan:mainfrom
SergioChan:fix-1328-inline-popup-delete-alias
Closed

Fix cells popup 'delete' string config resolving to global delete command#1339
SergioChan wants to merge 3 commits into
xdan:mainfrom
SergioChan:fix-1328-inline-popup-delete-alias

Conversation

@SergioChan

Copy link
Copy Markdown
Contributor

Description

  • fix inline-popup string button resolution to prefer the default popup control object for the current popup type when available
  • this keeps custom popup.cells: Jodit.atom([...]) entries like delete bound to the cells control definition (icon: bin, table delete list, custom exec) instead of falling back to the global delete command
  • scope is limited to inline popup toolbar normalization before build

Related Issue

Fixes #1328

Checklist

  • There is an associated issue labeled bug or enhancement
  • Code is up-to-date with the main branch
  • npm test passes locally
  • New or updated tests validate the change

Validation note: make is not executable in this runtime (make: Permission denied), so project lint/test commands could not be run here. Change was verified by code-path inspection against getControlType fallback behavior and popup toolbar build flow.

@SergioChan

Copy link
Copy Markdown
Contributor Author

Follow-up: I pushed commit 80a5310 to fix the CI lint failure (Prettier indentation in inline-popup.ts).

Validation run locally:

  • npm ci --legacy-peer-deps
  • ./node_modules/.bin/eslint ./src/plugins/inline-popup/inline-popup.ts

@xdan

xdan commented Jun 5, 2026

Copy link
Copy Markdown
Owner

Thanks a lot for digging into this and proposing a fix, @SergioChan! 🙏

Good news: both changes in this PR have already landed on main, so it's now a no-op:

  1. Cells popup string buttons (Customising the Jodit popup cell icons isn't working properly #1328) — the cell popup controls (valign, deleteTable, brushCell, …) are now registered as global controls specifically so they can be referenced by name in custom popup configs (see src/plugins/inline-popup/config/config.ts, commit d74271e"Fix custom cell popup buttons not working when referenced by name"). I verified on current main that popup: { cells: Jodit.atom(['valign', 'deleteTable']) } renders the correct bin icon + dropdown and actually deletes the table — no fallback to the global delete command.

  2. Resize handle visibilityeditor.statusbar.show() in resize-handler.ts is already there too (commit 75894da"Fix resize handle visibility when status counters are hidden").

So #1328 is already resolved in the released builds. Closing this as superseded, but thank you — the analysis was spot on. 🙌

@xdan xdan closed this Jun 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Customising the Jodit popup cell icons isn't working properly

2 participants