Skip to content

chore: fix npm dependency resolution - #1351

Closed
tonyganchev wants to merge 2 commits into
xdan:mainfrom
tonyganchev:main
Closed

chore: fix npm dependency resolution#1351
tonyganchev wants to merge 2 commits into
xdan:mainfrom
tonyganchev:main

Conversation

@tonyganchev

@tonyganchev tonyganchev commented Apr 2, 2026

Copy link
Copy Markdown
Contributor

Description

Folks, I am running an ecosystem test for your repo to guard against regressions in @tony.ganchev/eslint-plugin-header.

Starting today the job started failing not being able to resolve typescript@6 and @typescript-eslint/eslint-plugin@8.56.1: https://github.com/tonyganchev/eslint-plugin-header/actions/runs/23889574119/job/69659629545

The issue is also reproducible locally and started since 27276e2 which updated typescript to 6.0.2.:

npm error code ERESOLVE
npm error ERESOLVE could not resolve
npm error
npm error While resolving: @typescript-eslint/eslint-plugin@8.57.0
npm error Found: typescript@6.0.2
npm error node_modules/typescript
npm error   dev typescript@"^6.0.2" from the root project
npm error   peerOptional typescript@">=4.9.5" from cosmiconfig@9.0.1
npm error   node_modules/cosmiconfig
npm error     cosmiconfig@"^9.0.0" from postcss-loader@8.2.1
npm error     node_modules/postcss-loader
npm error       dev postcss-loader@"^8.2.1" from the root project
npm error     cosmiconfig@"^9.0.0" from stylelint@17.4.0
npm error     node_modules/stylelint
npm error       dev stylelint@"^17.4.0" from the root project
npm error       6 more (stylelint-config-recommended, ...)
npm error   2 more (ts-api-utils, ts-loader)
npm error
npm error Could not resolve dependency:
npm error peer typescript@">=4.8.4 <6.0.0" from @typescript-eslint/eslint-plugin@8.57.0
npm error node_modules/@typescript-eslint/eslint-plugin
npm error   dev @typescript-eslint/eslint-plugin@"^8.56.1" from the root project
npm error
npm error Conflicting peer dependency: typescript@5.9.3
npm error node_modules/typescript
npm error   peer typescript@">=4.8.4 <6.0.0" from @typescript-eslint/eslint-plugin@8.57.0
npm error   node_modules/@typescript-eslint/eslint-plugin
npm error     dev @typescript-eslint/eslint-plugin@"^8.56.1" from the root project
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.
npm error

I've bumped the offending @typescript-eslint/eslint-plugin to v.8.58.0 and it resolved the issue. make lint passed as well.

Related Issue

Fixes #

Checklist

  • There is an associated issue labeled bug or enhancement
  • Code is up-to-date with the main branch
  • npm test passes locally
  • New or updated tests validate the change

tonyganchev and others added 2 commits April 2, 2026 11:40
Folks, I am running an ecosystem test for your repo to guide against regressions in _@tony.ganchev/eslint-plugin-header_.

Starting today the job started failing not being able to resolve _typescript@6_ and _@typescript-eslint/eslint-plugin@8.56.1_:
https://github.com/tonyganchev/eslint-plugin-header/actions/runs/23889574119/job/69659629545

```
npm error code ERESOLVE
npm error ERESOLVE could not resolve
npm error
npm error While resolving: @typescript-eslint/eslint-plugin@8.57.0
npm error Found: typescript@6.0.2
npm error node_modules/typescript
npm error   dev typescript@"^6.0.2" from the root project
npm error   peerOptional typescript@">=4.9.5" from cosmiconfig@9.0.1
npm error   node_modules/cosmiconfig
npm error     cosmiconfig@"^9.0.0" from postcss-loader@8.2.1
npm error     node_modules/postcss-loader
npm error       dev postcss-loader@"^8.2.1" from the root project
npm error     cosmiconfig@"^9.0.0" from stylelint@17.4.0
npm error     node_modules/stylelint
npm error       dev stylelint@"^17.4.0" from the root project
npm error       6 more (stylelint-config-recommended, ...)
npm error   2 more (ts-api-utils, ts-loader)
npm error
npm error Could not resolve dependency:
npm error peer typescript@">=4.8.4 <6.0.0" from @typescript-eslint/eslint-plugin@8.57.0
npm error node_modules/@typescript-eslint/eslint-plugin
npm error   dev @typescript-eslint/eslint-plugin@"^8.56.1" from the root project
npm error
npm error Conflicting peer dependency: typescript@5.9.3
npm error node_modules/typescript
npm error   peer typescript@">=4.8.4 <6.0.0" from @typescript-eslint/eslint-plugin@8.57.0
npm error   node_modules/@typescript-eslint/eslint-plugin
npm error     dev @typescript-eslint/eslint-plugin@"^8.56.1" from the root project
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.
npm error
```

The issue is also reproducible locally and started since 27276e2 which updated _typescript_ to 6.0.2.

I've bumped the offending _@typescript-eslint/eslint-plugin_ to v.8.58.0 and it resolved the issue. `make lint` passed as well.
@xdan

xdan commented Jun 5, 2026

Copy link
Copy Markdown
Owner

Thanks a lot for catching this and for the thorough write-up, @tonyganchev! 🙏

This is the same problem as #1368. It's now fixed and released in 4.12.5 — I bumped both @typescript-eslint/eslint-plugin and @typescript-eslint/parser to ^8.60.1 and regenerated the lockfile, so npm ci resolves cleanly with TypeScript 6.

Closing this as resolved by that release, but very much appreciated.

@xdan xdan closed this Jun 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants