Skip to content

fix(security): sanitize smuggled html in disconnected elements and check location existence #1380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MatrixNeoKozak wants to merge 1 commit into from
Closed

fix(security): sanitize smuggled html in disconnected elements and check location existence #1380

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/core/helpers/html/safe-html.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@
const foreign = box.querySelectorAll('math *, svg *');

for (let i = 0; i < foreign.length; i++) {
if (foreign[i].isConnected && isSmuggledForeignHtml(foreign[i])) {
if (box.contains(foreign[i]) && isSmuggledForeignHtml(foreign[i])) {
Dom.safeRemove(foreign[i]);
}
}
Expand Down Expand Up @@ -219,7 +219,8 @@
// scheme (e.g. `java\tscript:`) — all of which the browser still resolves to
// `javascript:` on click. See GHSA-j839-gqq4-gf9j.
if (safeJavaScriptLink && href && isDangerousUrl(href, tagName)) {
attr(elm, 'href', location.protocol + '//' + href);
const protocol = typeof location !== 'undefined' ? location.protocol : 'http:';

Check failure on line 222 in src/core/helpers/html/safe-html.ts

View workflow job for this annotation

GitHub Actions / build 

Replace `·` with `⏎↹↹↹`
attr(elm, 'href', protocol + '//' + href);
effected = true;
}

Expand Down
22 changes: 22 additions & 0 deletions src/plugins/clean-html/clean-html.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -832,6 +832,28 @@
});
});

describe('smuggled HTML in MathML/SVG', function () {
it('Should remove HTML smuggled into MathML or SVG when parsed in disconnected fragment', function () {
const editor = getJodit({
cleanHTML: { useIframeSandbox: false }
});
editor.value = '<math><mglyph><html><body onload="alert(1)"></body></html></mglyph></math>';

Check failure on line 840 in src/plugins/clean-html/clean-html.test.js

View workflow job for this annotation

GitHub Actions / build 

Replace `·` with `⏎↹↹↹↹↹`
expect(editor.value).does.not.contain('onload');
expect(editor.value).does.not.contain('body');
});
});

describe('smuggled HTML in MathML/SVG', function () {
it('Should remove HTML smuggled into MathML or SVG when parsed in disconnected fragment', function () {
const editor = getJodit({
cleanHTML: { useIframeSandbox: false }
});
editor.value = '<math><mglyph><html><body onload="alert(1)"></body></html></mglyph></math>';

Check failure on line 851 in src/plugins/clean-html/clean-html.test.js

View workflow job for this annotation

GitHub Actions / build 

Replace `·` with `⏎↹↹↹↹↹`
expect(editor.value).does.not.contain('onload');
expect(editor.value).does.not.contain('body');
});
});

describe('denyTags (default: script,iframe,object,embed)', function () {
['script', 'iframe', 'object', 'embed'].forEach(function (tag) {
it('Should remove <' + tag + '> by default', function (done) {
Expand Down
2 changes: 1 addition & 1 deletion test/loader.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading