Support HTTPS homepage URLs and deprecate the \httplink macro #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moorereason
reviewed
Jan 23, 2017
CHANGELOG
Outdated
| @@ -1,3 +1,12 @@ | |||
| version 2.1.0 (unreleased) | |||
| - Deprecate the \httplink macro as it was to unflexible and did only support | |||
- Deprecate the \httplink macro as it was too inflexible and did only support
links to URLs using the (legacy) HTTP schema and not the new default HTTPS. Use \link.
- Change the format of the \homepage macro to support HTTPS homepage URLs.
Note that you will need to update your \homepage calls to make it work with
the new version.
- Switche \social URLs to HTTPS which has long been the default for all the
sites supported by \social.
Partly mechanical edit:
```Shell
git ls-files -z "$(git rev-parse --show-toplevel)" | xargs --null -I '{}' find '{}' -type f -print0 | xargs --null sed --in-place --regexp-extended 's#\\isundefined\{\\@homepage\}#\\isundefined{\\@homepage@url}#g;s#\\httplink\{\\@homepage\}#\\link\[\\@homepage@text\]\{\\@homepage@url\}#g;'
```
Closes: xdanaux#6
Related patchset: xdanaux#40
There should be *no* reason, for people to downgrade to http links just
because moderncv only supports legacy URL schemes. Ref:
gshakhn/resume@b8c93b9
|
Maybe not part of this pull request, but how about printing warnings when deprecated macros are used? |
|
Anything happening to this issue ? It would make tons of sense to deprecate the http:// scheme for the social networks macros in favour of https://. Any reason not to adopt ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that you will need to update your \homepage calls to make it work with the new version.
Partly mechanical edit:
Closes: #6
Related patchset: #40
There should be no reason for people to downgrade to http links just because moderncv only supports legacy URL schemes. Ref: gshakhn/resume@b8c93b9