Skip to content

Commit

Permalink
Add Video and Image diemensions field in respective class
Browse files Browse the repository at this point in the history
Both classes ImageConversationCard and VideoConversationCard
have field which have data related to dimensions/size of Video/Image
but these fields despite present in API are being dropped/ignored in
class properties/attributes, thus consumer of this library can't
assess data like 'image_display_height' on ImageConversationCard till
now. Current fix enable the same.
  • Loading branch information
Himanshu Patel authored and himanshu-patel-dev committed Oct 26, 2024
1 parent 0b6759a commit 5c07f1d
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
2 changes: 2 additions & 0 deletions lib/twitter-ads/creative/image_conversation_card.rb
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@ class ImageConversationCard
property :third_cta
property :third_cta_tweet
property :title
property :image_display_height
property :image_display_width

RESOURCE_COLLECTION = "/#{TwitterAds::API_VERSION}/" \
'accounts/%{account_id}/cards/image_conversation' # @api private
Expand Down
2 changes: 2 additions & 0 deletions lib/twitter-ads/creative/video_conversation_card.rb
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@ class VideoConversationCard
property :third_cta_tweet
property :title
property :media_key
property :video_width
property :video_height

RESOURCE_COLLECTION = "/#{TwitterAds::API_VERSION}/" \
'accounts/%{account_id}/cards/video_conversation' # @api private
Expand Down

0 comments on commit 5c07f1d

Please sign in to comment.