core: add quantum operation attribute superclasses - #64
Open
alexarice wants to merge 2 commits into
Open
Conversation
kimworrall
reviewed
Jul 27, 2026
kimworrall
left a comment
There was a problem hiding this comment.
Seems sensible. Added some nitpicks to the documentation to make it clearer.
|
Before we go ahead I'd like to test some different examples. |
alexarice
commented
Jul 27, 2026
Contributor
Author
I don't understand this comment, but no rush on this |
Contributor
Author
|
I'd like to be able to eventually capture:
The current system can do that, and I thought this is what we converged to on the board, but happy to head alternatives. |
Contributor
Author
|
I'll also reformat once we're done with small changes |
alexarice
force-pushed
the
alexarice/instrument
branch
from
July 31, 2026 14:12
5f3cc61 to
f2a224f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prototype for new "gate" superclass. Idea is to capture
all in one class.
I'm not really sure if there's a way to test it until adding some gates.