Skip to content

Conversation

@GachaDev
Copy link
Collaborator

@GachaDev GachaDev commented Apr 8, 2025

Insert spotless plugin with configuration and dependencies installed

Copy link
Collaborator

@Montagon Montagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should merge this first, in order to have the project updated. Another thing is that, we could add some CI check to build the project and pass spotless, what do you think?

@GachaDev GachaDev changed the base branch from 11-create-get-details to main April 9, 2025 06:45
@GachaDev GachaDev changed the base branch from main to 11-create-get-details April 9, 2025 06:47
@GachaDev
Copy link
Collaborator Author

GachaDev commented Apr 9, 2025

I think we should merge this first, in order to have the project updated. Another thing is that, we could add some CI check to build the project and pass spotless, what do you think?

We can go ahead and merge this first, but the branch now includes all the commits from the other branches. How can I revert all the changes that aren't part of the main base?
Also, would it be necessary to close this PR and open a new one with only the current spotless changes?

@Montagon
Copy link
Collaborator

Montagon commented Apr 9, 2025

I think we should merge this first, in order to have the project updated. Another thing is that, we could add some CI check to build the project and pass spotless, what do you think?

We can go ahead and merge this first, but the branch now includes all the commits from the other branches. How can I revert all the changes that aren't part of the main base? Also, would it be necessary to close this PR and open a new one with only the current spotless changes?

Ah, right! Well, no problem. Let's go with the other ones, no problem!

Base automatically changed from 11-create-get-details to main April 9, 2025 13:14
@Montagon
Copy link
Collaborator

Montagon commented Apr 9, 2025

I think we should merge this first, in order to have the project updated. Another thing is that, we could add some CI check to build the project and pass spotless, what do you think?

We can go ahead and merge this first, but the branch now includes all the commits from the other branches. How can I revert all the changes that aren't part of the main base? Also, would it be necessary to close this PR and open a new one with only the current spotless changes?

I would do the spotless here, adding and applying. To be clear. Next issue could be adding the GitHub actions for running spotless and tests.

@GachaDev GachaDev linked an issue Apr 9, 2025 that may be closed by this pull request
@GachaDev
Copy link
Collaborator Author

I think we should merge this first, in order to have the project updated. Another thing is that, we could add some CI check to build the project and pass spotless, what do you think?

We can go ahead and merge this first, but the branch now includes all the commits from the other branches. How can I revert all the changes that aren't part of the main base? Also, would it be necessary to close this PR and open a new one with only the current spotless changes?

I would do the spotless here, adding and applying. To be clear. Next issue could be adding the GitHub actions for running spotless and tests.

Done @Montagon ! I applied all the changes with spotless and i created a new issue for Github actions.

@GachaDev
Copy link
Collaborator Author

Github Action created here #18

@GachaDev GachaDev added this pull request to the merge queue Apr 10, 2025
Merged via the queue into main with commit 0cd4254 Apr 10, 2025
@GachaDev GachaDev deleted the 14-insert-spotless-plugin branch April 10, 2025 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Insert Spotless plugin

2 participants