Add spaced used metric to system info in the dash#47
Conversation
|
I would still kind of like it to just be used space as it does present a lot cleaner from an enduser facing perspective, and it removes a lot of the extra logic making the code simpler for the page, but it's up to you all, thank you Ryzee for putting in the effort on making this look so good |
| } | ||
| } | ||
|
|
||
| push_line(line++, toggle_space_display, show_used_space ? "Press A to show Available Space" : "Press A to show Used Space"); |
There was a problem hiding this comment.
Personally I'd just set it to used space without a toggle, which feels more aligned with how Windows (and macOS) displays it, given that the user base seems to be largely made of Windows users.
If we do have a toggle it feels like it'd be better as a persistent config file setting rather than something users would have to interact with on each boot.
There was a problem hiding this comment.
yes this is how I felt about it as well. this was more meant to be a rough draft to see if it could be changed to solely used space, I'd like to remove everything else, but was waiting for you/ryzee/matt to give some criticism.
There was a problem hiding this comment.
following this conversation, I changed this around to only reflect being used space like I initially intended to do this
There was a problem hiding this comment.
Yeah, I think just going with '% used' is reasonable. Not sure we need to have a toggle or have this be configurable.
|
Thanks! Happy with this change 😃 |
4 participants
This came up as part of a conversation with a user where it wasn't incredibly clear as to the used space on their drive, and it was a fair point given a lot of tools do show that metric in the form of used space, instead of available space, and I think it does appear better formatted that way.
I initially wanted to ditch the space available part entirely, but I figured that I'd add it as a toggle that way it'd be more likely to be accepted :p