ui: Align shortcut handling with ImGui Ctrl/Cmd model #2598
+7
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates shortcut detection logic to match Dear ImGui’s current input model,
where Ctrl and Cmd are automatically swapped on macOS.
Background
Starting with ImGui v1.92.5, the shortcut modifier handling was simplified:
Ctrl/Cmd mapping on macOS is now handled internally by ImGui, and
ImGuiMod_Shortcutwas removed.As a result, application code no longer needs to special-case macOS
or explicitly check for
KeySuper.What changed
Ctrlas the canonical cross-platform shortcut modifierReferences
ocornut/imgui@7747106