[Docs] Various corrections to VMX128 documentation #2331
+27
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The VMX128 documentation seems to contain some errors and missing instructions. I have made some corrections based on findings from the Xenia implementation, and a few other sources such as:
More specifically:
stvewx128xenia/tools/ppc-instructions.xml
Lines 1596 to 1601 in dfa1b3f
vandc128xenia/tools/ppc-instructions.xml
Lines 1770 to 1775 in dfa1b3f
vrlw128xenia/tools/ppc-instructions.xml
Lines 2491 to 2496 in dfa1b3f
vsro128xenia/tools/ppc-instructions.xml
Lines 2669 to 2674 in dfa1b3f
vupkhsh128xenia/src/xenia/cpu/ppc/ppc_emit_altivec.cc
Lines 2026 to 2029 in dfa1b3f
xenia/src/xenia/cpu/ppc/ppc_emit_altivec.cc
Lines 1988 to 1992 in dfa1b3f
vupklsh128xenia/src/xenia/cpu/ppc/ppc_emit_altivec.cc
Lines 2047 to 2050 in dfa1b3f
xenia/src/xenia/cpu/ppc/ppc_emit_altivec.cc
Lines 2006 to 2010 in dfa1b3f
I made this effort while working on NationalSecurityAgency/ghidra#2094, see NationalSecurityAgency/ghidra#2094 (comment) for more details.
I thought Xenia would be a good place for hosting the updated VMX128 documentation since it is useful for Xenia, and we have Git version control here.
Let me know if you have any questions.