SWA deployment fixes#227
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to resolve Azure Static Web Apps (SWA) deployment/runtime issues by adding SWA routing configuration, correcting deployment naming, and moving the SWA resource to the Standard tier.
Changes:
- Added
staticwebapp.config.jsonto support SPA navigation fallback behavior in the React frontend. - Updated the GitHub Actions workflow to correct the target Web App name and pass
VITE_API_BASE_URLduring the React build. - Changed the SWA Bicep module SKU from Free to Standard and included the module in the solution.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/frontend/Sudoku.React/public/staticwebapp.config.json |
Introduces SWA navigation fallback + MIME type config for the React SPA. |
infra/modules/staticwebapp.bicep |
Updates SWA SKU to Standard tier. |
Sudoku.sln |
Adds the SWA Bicep module into the solution’s infra modules list. |
.github/workflows/main.yml |
Fixes Web App name casing, injects VITE_API_BASE_URL for frontend build, and tightens deploy job conditions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| { | ||
| "navigationFallback": { | ||
| "rewrite": "/index.html", | ||
| "exclude": ["/images/*", "/css/*", "/js/*", "*.{png,jpg,svg,ico,json,woff,woff2,ttf,eot}"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes some deployment issues with the SWA. Bumps up the SWA tier.
Type of Change
Changes Made
Testing
Screenshots (if applicable)
Checklist