Fix code rule violations#258
Merged
Merged
Conversation
…numbers, comments - Replace InvalidOperationException with CellAlreadyHasValueException in Cell and SudokuGame (domain layer must only throw domain exceptions) - Remove unreachable try/catch in UpdateProfileAliasCommandHandler wrapping a LogDebug call - Extract difficulty empty-cell ranges to named constants in PuzzleGenerator - Remove what-comments and multi-line docstring from Cell value object - Update two tests to assert CellAlreadyHasValueException Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://gray-bush-02024e71e-258.westus2.7.azurestaticapps.net |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes violations of the project's defined rules found via a codebase review against
.claude/rules/standards.Type of Change
Changes Made
CellAlreadyHasValueExceptionand replaced twoInvalidOperationExceptionthrows inCell.AddPossibleValueandSudokuGame.AddPossibleValueToCell— domain layer must only throw domain-specific exceptionstry/catch(Exception)inUpdateProfileAliasCommandHandlerthat wrapped only aLogDebugcall (nothing inside could throw)private const intconstants inPuzzleGeneratorCellthat described what the code already made obviousInvalidOperationExceptionto assertCellAlreadyHasValueExceptionTesting
Screenshots (if applicable)
N/A
Checklist