Skip to content

Conversation

@nwlandry
Copy link
Collaborator

This PR

  • Removes seaborn as a a dependency
  • Adds tuna to help profile imports

@codecov
Copy link

codecov bot commented May 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.62%. Comparing base (429ea32) to head (bc3cffb).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #676   +/-   ##
=======================================
  Coverage   93.62%   93.62%           
=======================================
  Files          66       66           
  Lines        5110     5113    +3     
=======================================
+ Hits         4784     4787    +3     
  Misses        326      326           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@kaiser-dan
Copy link
Collaborator

kaiser-dan commented Jan 2, 2026

I've made a few additional miscellaneous fixes to this PR:

  • mako and mako_r are also seaborn palettes alongside the already addressed crest. Unlike the earlier changes, I did not define this color palette but instead removed it from all the examples. I replaced it with plasma.
  • The updates to importing, I suspect from tuna's insights, had some incomplete changes to calling the factorial function
  • The node drawing function wanted x and y passed as positional arugments for the downstream Axes3D.scatter call

UPDATE:
I've checked the CI logs and I believe the failing tests are 429 request errors from the xgi_data tests and don't have to do with any of the other functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants