Add logging wrappers to LdapService calls #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add log statement for successful auth - we don't expect this to be called often, but if we have it enabled we are prob paying close attention to some auth-related issue - seems helpful to give ourselves more insight as to what's happening with user auth requests.
amcclain
commented
Feb 5, 2025
| @@ -192,7 +207,7 @@ class LdapService extends BaseService { | |||
| List<T> ret = cache.get(key) | |||
| if (ret != null) return ret | |||
|
|
|||
| withDebug(["Querying LDAP", [host: host, filter: filter]]) { | |||
| withTrace(["Querying LDAP", [host: host, filter: filter]]) { | |||
There was a problem hiding this comment.
This is the lowest-level query call which will be executed (potentially a number of times) as part of all the higher-level requests. Thinking this makes the most sense to be on trace.
|
Opened as a draft b/c I have not yet run this code, but I would like to get this in with the next release if we can verify. I think the changes should be clear and I did my best to be careful, but always want to be up-front about code that's not yet been run! (Discussed need for proper Hoist-side LDAP test env on Slack yesterday - can aim to get that done, or fold this into on-prem testing.) |
|
Merging, we'll test this post merge in the field for sure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.