-
Notifications
You must be signed in to change notification settings - Fork 11
CodeInput/JsonInput should format automatically in readOnly mode. #3937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
ef3c359
feat(jsonInput): format the provided value to display properly
RyanMG 4edcfad
refactor(jsonInput): remove auto formatting of JSON data for connecti…
RyanMG 3bcf2ff
post-pr review updates to jsonInput formatting update
RyanMG eae1a14
doc: update CHANGELOG for the jsonInput format update
RyanMG aab149f
codeInput autoformatting update - prop to auto format the display whe…
RyanMG a9035ef
clean up activity detail admin JSON display
RyanMG 5806d9f
Merge branch 'develop' into remove-json-preformat
RyanMG 50cbf39
doc: CHANGELOG update to account for version bump
RyanMG 27bd0f5
revert original batch of jsonInput changes
RyanMG 97b36ec
have the default formatter for jsonInput be the safe version of the J…
RyanMG ae1a065
method name update from formatValue -> formatAndSetEditorValue to bet…
RyanMG d64e207
Merge branch 'develop' into remove-json-preformat
RyanMG 82c3900
Remove jest testing code which got stuck and commited on accident
RyanMG a20c17a
Merge branch 'develop' into remove-json-preformat
RyanMG d9c3cb1
Return some of the changes done by the linted automatically
RyanMG ead237a
Merge remote-tracking branch 'origin/develop' into remove-json-preformat
lbwexler cb4e99b
Add CHANGELOG entry for jsonInput autoFormat / safe formatting
lbwexler 608e72e
Merge remote-tracking branch 'origin/develop' into remove-json-preformat
lbwexler 14f3a70
Default codeInput autoFormat on for readonly inputs; warn if set on e…
lbwexler e8e66b3
Drop redundant manual JSON pretty-printing for readonly jsonInputs
lbwexler bc42d4d
Use warnIf for autoFormat-on-editable warning
lbwexler 6b5ad76
Make timestamp-formatted readonly jsonInputs declarative
lbwexler da4eabc
Drop redundant safeFmtJson; rely on CodeInput's formatter try/catch
lbwexler 1f48163
Drop redundant filter.toJSON() - JSON.stringify invokes it automatically
lbwexler 4b3e072
Bind pool config jsonInput to poolConfiguration model observable
lbwexler 2dcb74d
Resolve pool config bind via context model lookup
lbwexler b50bc4a
Extract shared adminJsonDisplay for readonly admin JSON panels
lbwexler 0b5c63e
Build flex: 1 into adminJsonDisplay default sizing
lbwexler d9b6286
Bind DetailPanel json display to selectedAdminStats
lbwexler 75e9b4d
Bind service DetailsPanel json display to stats
lbwexler 0e1fade
checkpoint
lbwexler aa987a4
Note readonly JsonInput call-site simplification in CHANGELOG
lbwexler ae9f1e0
Merge remote-tracking branch 'origin/develop' into remove-json-preformat
lbwexler 762eeea
Allow autoFormat on editable CodeInput (formats on blur)
lbwexler dd958c7
Enable autoFormat on editable JSON editors (grid filter, REST form)
lbwexler 7b56d3a
tweaks from code review
lbwexler File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.