Add dynamic routable tabs spike example app#837
Draft
amcclain wants to merge 1 commit into
Draft
Conversation
Exploratory spike demonstrating dynamic, routable tabs using TabContainerModel with DynamicTabSwitcher and Router 5 integration. All 7 target routing scenarios work via a manual routing workaround. Key finding: TabContainerModel's built-in `route` config cannot be used with dynamic tabs — addTab/removeTab both call setTabs() which throws when routing is enabled. The workaround manages Router 5 ↔ tab sync manually with a direct router subscription and MobX reactions. Additional friction points discovered and documented: Router 5's isActive() requires params for parameterized routes, MobX reactions don't reliably detect param-only route changes, DynamicTabSwitcher's hide() doesn't remove tabs from the container, and cleanup reactions race with tab creation due to MobX batching. See FINDINGS.md for full analysis and recommended framework changes. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Member
Author
|
Not necessarily expecting this to get merged - opening as a draft PR mostly for easy viewing of the diff and discussion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exploratory spike demonstrating dynamic, routable tabs using TabContainerModel with DynamicTabSwitcher and Router 5 integration. All 7 target routing scenarios work via a manual routing workaround.
Key finding: TabContainerModel's built-in
routeconfig cannot be used with dynamic tabs — addTab/removeTab both call setTabs() which throws when routing is enabled. The workaround manages Router 5 ↔ tab sync manually with a direct router subscription and MobX reactions.Additional friction points discovered and documented: Router 5's isActive() requires params for parameterized routes, MobX reactions don't reliably detect param-only route changes, DynamicTabSwitcher's hide() doesn't remove tabs from the container, and cleanup reactions race with tab creation due to MobX batching.
See FINDINGS.md for full analysis and recommended framework changes.