Add frontend handling for move line#278
Open
nangtrongvuon wants to merge 1 commit intoxi-editor:masterfrom
Open
Add frontend handling for move line#278nangtrongvuon wants to merge 1 commit intoxi-editor:masterfrom
nangtrongvuon wants to merge 1 commit intoxi-editor:masterfrom
Conversation
cmyr
approved these changes
Oct 3, 2018
Member
cmyr
left a comment
cmyr
left a comment
There was a problem hiding this comment.
Looks good, feel free to merge this whenever the core PR goes in. 😎
nangtrongvuon
force-pushed
the
move-line-frontend
branch
from
900723f to
cedf8c6
Compare
Codecov Report
@@ Coverage Diff @@
## master #278 +/- ##
==========================================
- Coverage 45.87% 43.96% -1.91%
==========================================
Files 30 30
Lines 3863 3867 +4
==========================================
- Hits 1772 1700 -72
- Misses 2091 2167 +76
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds frontend support for moving lines.
The default hotkeys are
Alt + Up/Downfor move lines up/down respectively.Depends on xi-core's #849.