improve Dockerfile: use cache, add .dockerignore #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpoussin
force-pushed
the
docker-wa
branch
6 times, most recently
from
04b2fa0 to
9bab63a
Compare
Owner
|
The WASM module does not need to be compiled unless there are changes to the code in the cpp folder. The Dockerfile in the root directory should not include compilation scripts for WASM. If adding Docker-based compilation for the WASM module, it should be written in a separate Dockerfile (e.g., Dockerfile-wasm). |
Author
|
Alright, I'll make a couple changes |
fpoussin
changed the title
Owner
|
Additionally, Ninja has been configured in the CMakePresets.json. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've updated the Dockerfile to use cache and ignore unnecessary files.