refine: propose adjustments to 1 rule(s) - #817
Open
claude[bot] wants to merge 1 commit into
Open
Conversation
Co-Authored-By: Claude Code <noreply@anthropic.com>
Contributor
🔍 Preview deployPreview URL: https://nlpm.com/_pr/817/ Built from It may take 30–60s for the GitHub Pages CDN to serve the new content. The preview is removed automatically when the PR closes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
R15 — noisy (evidence tagged
R19in the auditor's proposal)Current metrics: hits=4, merged/contributed=0/0, self-FP=3, maintainer-rejected=0, downstream-suppressions=0
Evidence:
Proposed change: The input labeled this proposal
R19, but the gap text names "the no-empty-input-handling rule," which is R15 ("Handle empty input") perskills/nlpm/scoring/SKILL.md's rule-name table — R19 governsuser-invocable: false, an unrelated frontmatter requirement.R19already carries an equivalent exception ("Does not apply to: standalone commands, including commands whose body is a single unconditional message") from a prior refinement round, so no edit was needed there. Given the self-FP rate (3 of 4 hits) and the gap text, I applied the analogous exception to R15 instead: commands whose body is a single unconditional message with no branching on$ARGUMENTShave nothing to guard against, so they're now exempt from the empty-input-handling requirement. Flagging the rule_id mismatch explicitly for reviewer judgment — reject this edit if the retagging reasoning doesn't hold.Proposals without evidence
downstream_reasonshas 5 entries but everyreasonfield is literally"(no reason given)"(allthreshold_adjustmenttype, which doesn't correspond to R31's fail-open-hooks content) — no actionable signal.Not applicable to this file
skills/nlpm/rules/SKILL.md; it's a security-scanner pattern (skills/nlpm/security/SKILL.md). Persite/how-it-evolves.md, this was already "demoted" viarule-health.pyclassifier logic inv0.7.22, not via rulebook wording — out of scope for this PR, which may only touchskills/nlpm/rules/SKILL.md.applied_separatelyreclassification fix inrule-health.py(v0.7.22).skills/nlpm/security/SKILL.md, not the rules catalog. Recommend routing this fix to a security-skill-focused refinement pass; no edit made here.