flac.md: fix "-q" misinformation, and more. #818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* max -q value was wrong, issue xiph#816 . Fixed that. * Also, reworded -m, -M for clarity, -p for consistency with -q, --lax for brevity. * This should have been done in the previous round: the --help text has the tagging options right after --picture. Did so here too. * But, and this should either also be fixed in the help text or be rejected: --no-utf-8 is a tagging option - aren't those encoding-only? Moved and reworded, but reject as appropriate.
Reworded the wording of -j, correcting the max to the actual 64.
|
Looks like max thread count was wrong as well. Also reworded, clarifying that default is single-thread. |
ktmf01
reviewed
Apr 12, 2025
|
|
||
| **-M**, **\--adaptive-mid-side** | ||
| : Adaptive mid-side coding for all frames (stereo only, otherwise ignored). | ||
| : Like -m, but adaptive choice (faster, slightly weaker compression). |
There was a problem hiding this comment.
Maybe use the word heuristics here? I think that is more descriptive than adaptive. I know, the word adaptive was there already, but it is rather unclear what it means I think
There was a problem hiding this comment.
No objection to that. I'll look over it and - if you don't mind doing it in this thread - submit more textual suggestions. I have briefly tested picture and RG features and tried to make sense out of actual behaviour vs help text, so a question -- indeed two:
- Could RG still leave PADDING even if --no-padding is used? I didn't get to provoke that. Looks like something similar was addressed in 1.2.1b?
- General formatting: Should one more generally write out e.g.
-wwith ticks instead of -w without? I assume it would be a good thing to write flac double-asterisk-surrounded for the tool, to contrast it from the format (which likely should be FLAC in allcaps?), that is quite common manpage style?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hope I haven't messed up how pulls work. Wouldn't be the first time.
This intends to fix #816 , the man page wrongly states -q 16 is permitted.
I have worked on more on the man page, but I don't want to put in too much in one request.