Fix problem with SetConsoleOutputCP CP_UTF8 on Windows#896
Open
madah81pnz1 wants to merge 2 commits intoxiph:masterfrom
Open
Fix problem with SetConsoleOutputCP CP_UTF8 on Windows#896madah81pnz1 wants to merge 2 commits intoxiph:masterfrom
madah81pnz1 wants to merge 2 commits intoxiph:masterfrom
Conversation
Also splits up the WriteConsoleW() calls if the buffer is too big, as this was at least a problem in Windows 7 and earlier.
Contributor
Author
|
Note this needs more testing, especially piping binary from stdin. Also might need another test binary to be able to test windows console output properly, e.g. by calling ReadConsoleW() to check what was actually written. |
Contributor
Author
Reading from stdin turns into mojibake, e.g. --import-tags-from-file=- |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.