Fix compilation on MSVC #16
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No one seems to be interested? |
`strncasecmp()` does not exist in MSVC so declare it is the same as `_strnicmp()`.
|
This fix seem incomplete, as strncasecmp() is used in ogg123/remote.c, ogg123/vorbis_comments.c and ogg123/cfgfile_options.c too. Are you not building ogg123 on MSVC? |
|
There is a similar define in intl/os2compat.h for OS/2. Perhaps a similar header file to work around brokenness on MSVC is a good idea? |
No I am not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
strncasecmp() does not exist in MSVC so define it as _strnicmp()