Kcz/add mp4 spliting into frames#3
Closed
krzyczar wants to merge 135 commits intoxipingyan:masterfrom
krzyczar:kcz/add_mp4_disabling_into_frames
Closed
Kcz/add mp4 spliting into frames#3krzyczar wants to merge 135 commits intoxipingyan:masterfrom krzyczar:kcz/add_mp4_disabling_into_frames
krzyczar wants to merge 135 commits intoxipingyan:masterfrom
krzyczar:kcz/add_mp4_disabling_into_frames
Conversation
Signed-off-by: xipingya <xiping.yan@intel.com>
Signed-off-by: xipingya <xiping.yan@intel.com>
Signed-off-by: xipingya <xiping.yan@intel.com>
Signed-off-by: xipingya <xiping.yan@intel.com>
Only calc once for video process. Signed-off-by: xipingya <xiping.yan@intel.com>
Signed-off-by: xipingya <xiping.yan@intel.com>
2: add ov::Properity::video Signed-off-by: xipingya <xiping.yan@intel.com>
Co-authored-by: Wanglei Shen <wanglei.shen@intel.com>
# Conflicts: # src/cpp/src/continuous_batching/pipeline_base.cpp # src/cpp/src/visual_language/inputs_embedder.cpp # src/cpp/src/visual_language/inputs_embedder.hpp # src/cpp/src/visual_language/qwen2vl/classes.cpp # src/cpp/src/visual_language/qwen2vl/classes.hpp
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…om/xipingyan/openvino.genai into xp/enable_qwen_vl_video_preprocess
Signed-off-by: xipingya <xiping.yan@intel.com>
Signed-off-by: xipingya <xiping.yan@intel.com>
Signed-off-by: xipingya <xiping.yan@intel.com>
Signed-off-by: xipingya <xiping.yan@intel.com>
Signed-off-by: xipingya <xiping.yan@intel.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: xipingya <xiping.yan@intel.com>
Signed-off-by: xipingya <xiping.yan@intel.com>
Add "video" to continues batching. Signed-off-by: xipingya <xiping.yan@intel.com>
Signed-off-by: xipingya <xiping.yan@intel.com>
Signed-off-by: xipingya <xiping.yan@intel.com>
Signed-off-by: xipingya <xiping.yan@intel.com>
Signed-off-by: xipingya <xiping.yan@intel.com>
Signed-off-by: xipingya <xiping.yan@intel.com>
2:Add: mix video+image inputs. Signed-off-by: xiping.yan <xiping.yan@intel.com>
<video_pad> + <image_pad>, so put video to ahead of image. keep align with genai. Signed-off-by: xiping.yan <xiping.yan@intel.com>
2: Split video and image process. 3: Fix copy embed feature bug. Signed-off-by: xipingya <xiping.yan@intel.com>
Signed-off-by: xiping.yan <xiping.yan@intel.com>
Signed-off-by: xiping.yan <xiping.yan@intel.com>
Signed-off-by: xiping.yan <xiping.yan@intel.com>
Signed-off-by: xiping.yan <xiping.yan@intel.com>
Signed-off-by: xiping.yan <xiping.yan@intel.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
wrapper calculate_product Signed-off-by: xiping.yan <xiping.yan@intel.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: xiping.yan <xiping.yan@intel.com>
Signed-off-by: xiping.yan <xiping.yan@intel.com>
Signed-off-by: xipingya <xiping.yan@intel.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: xiping.yan <xiping.yan@intel.com>
|
fyi @Wovchena |
Wovchena
reviewed
Oct 24, 2025
| if input_data.get("video", None): | ||
| entry = Path(input_data["video"]) | ||
| ordered_frames = pu.split_video_into_frames(entry, required_frames) | ||
| images.extend(ordered_frames) |
There was a problem hiding this comment.
That indeed interprets a video as images. Just like the title says. But GenAI started supporting video input as a separate entity. What's the reason to split the video into frames?
sbalandi
reviewed
Oct 24, 2025
| gen_fn = run_visual_language_generation_optimum | ||
| else: | ||
| gen_fn = run_visual_language_generation_genai | ||
| if use_genai: gen_fn = run_visual_language_generation_genai |
There was a problem hiding this comment.
please, use ternary operator or keep previous variant, multiline code is more readable
| else: | ||
| raise RuntimeError('== key word "prompt" does not exist ==') | ||
| prompt_data = create_base_prompt(json_data) | ||
| assert ("media" in json_data) ^ ("video" in json_data) |
There was a problem hiding this comment.
please, add message fo assert, but its better to use raise RuntimeError
| if args['prompt_file'] is not None and len(args['prompt_file']) > 0: | ||
| vlm_file['media'] = model_utils.resolve_media_file_path(vlm_file.get("media"), args['prompt_file'][0]) | ||
| if args['prompt_file'] is not None and len(args['prompt_file']) > 0 and 'media' in vlm_file: | ||
| if 'video' in vlm_file: log.warning('media and video cannot be specify in a single prompt file') |
There was a problem hiding this comment.
we have warning here, but assert above, let's rise exeption in both cases
krzyczar
changed the base branch from
xp/enable_qwen_vl_video_preprocess
to
master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ticket:
Fixes #(issue)
Checklist: