Skip to content

feat: add URL support for projects, update PDF generation #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add URL support for projects, update PDF generation #129

wants to merge 1 commit into from

Conversation

psocbitm
Copy link

Detailed description of what was changed and why:

  • Added support for adding links in the PDF
  • Users can simply provide a valid project URL and the project name will be highlighted and a link will be attached to the project name field.
  • There was a bug because of which after changing ny field it wasn't reflected in the PDF. For this I've passed document instance to update PDF hook.

Related issues:

Closes #101

@vercel Vercel
Copy link

vercel bot commented Nov 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
open-resume ❌ Failed (Inspect) Nov 28, 2024 5:59pm

@psocbitm
Copy link
Author

@xitanggg Can you please review the code for issue #101 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Project Links Required
2 participants
@psocbitm @x-ash-x