[DRG] LvL 90 Ultimate sim by wolfcomp · Pull Request #345 · xiv-gear-planner/gear-planner

wolfcomp · 2024-10-11T23:08:03Z

Has all of DRG ability actions for up to LvL 90 in use for TOP and DSR

Notes

Life of the dragon is just printed as a name as it's a time based buff that is shown through the Gauge and has no icon attached to it

wolfcomp · 2024-10-28T13:47:11Z

If it complains about linting, I have no idea how to get the same linter to run on my machine to actually fix it as this is the result i get

wolfcomp · 2024-11-30T22:30:38Z

finally got the linter to show the same as the workflow so now this should be happy

VioletHynes · 2024-12-01T18:43:00Z

+    name: "Drakesbane",
+    id: 36952,
+    attackType: "Weaponskill",
+    potency: 400,


I know this sim only supports level 90 for now, but if other levels were being added in the future, it'd be great if we used levelModifiers on these abilities to represent their potencies at other levels, so that we only needed to support one list of DRG abilities and not maintain a separate list for every level. For example, from the DRK sim:

export const HardSlash: DrkGcdAbility = { type: 'gcd', name: "Hard Slash", id: 3617, potency: 150, attackType: "Weaponskill", gcd: 2.5, appDelay: 0.58, cast: 0, levelModifiers: [ { minLevel: 84, potency: 180, }, { minLevel: 94, potency: 300, }, ], };

I noticed this because Drakesbane is 440 potency at level 100 :)

I would say that this is something that should be done if the other sims gets implemented and not tossed to this portion.

VioletHynes · 2024-12-01T18:43:29Z

+    },
+    supportedJobs: ["DRG"],
+    supportedLevels: [90],
+    isDefaultSim: false,


Should this be true?

I would say only the end level sim should be the default which would be in this case 100

A default sim will show up only for its supported levels, so you should be safe here. If setting this to true makes the sim show up for level 100 gearsets, then there'd be a bug

VioletHynes · 2024-12-01T18:46:23Z

+        return new DrgTopSim(exported);
+    },
+    supportedJobs: ["DRG"],
+    supportedLevels: [90],


There's probably not a lot of extra work to get this supported for level 100, too, though I understand that is some extra work, and it's fine to not want to address that for now.

If we did this, we wouldn't need to call it drg_top_sim either, it'd just be drg_sheet_sim. If you're interested in an example, DRK supports 70-100.

I would rather not have to maintain an Excel sheet thing in order for this to work. I know that it is something that could be done, and more me just not wanting to rely on other services working for a single sim to work.

Perhaps the nomenclature is confusing here, but "sheet" in this comment doesn't mean an Excel sheet, it means gearsheet. This wouldn't mean needing to support any other service, it's just a naming thing. Most of our sims are called job_sheet_sim etc.

also fix merge conflicts

VioletHynes · 2024-12-18T16:36:40Z

+    type: 'ogcd',
+    name: "Nastrond",
+    id: 7400,
+    potency: 360,


This (and Nastrond Ready) will need to be updated following the balance patch.

VioletHynes · 2024-12-18T16:37:40Z

+                    const span = document.createElement('span');
+                    span.textContent = `${firstmindsFocus}`;
+
+                    const barOuter = document.createElement('div');


nit: instead of a bar, we could consider using circles to note stacks, like the Monk Sim for Chakras or the GNB sim for carts

VioletHynes · 2024-12-18T16:38:21Z

+        dmgIncrease: 0.15,
+    },
+    duration: 20,
+    // No status ID due to being a hidden buff


Since it's hidden, it would be great to show in the UI

It both is hidden and not hidden. The reason being that the status itself isn't a displayed thing, but it does show it through the Job Gauge with a countdown timer

Life of the Dragons 15% damage up still has to be shown in the total buffs column and it should be listed with an icon to make it more readable. While there is no direct buff icon for it in game, the status icon for LotD still exists https://arcanedisgea.github.io/xiv-id/?index=Status&query=life+of+the+dragon
We always display it as an active buff in our rotation builders so people are used to seeing it.

VioletHynes · 2024-12-18T16:46:55Z

+            apply(cp: DRG90CycleProcessor) {
+                const numPots = Math.ceil(cp.remainingTime / 360); // Force pots during 2mins
+                const maxAllowableDelay = cp.remainingTime - ((numPots - 1) * 360);
+                const potOpener = maxAllowableDelay <= 120;


The pot doesn't seem to be applying in the opener from the image, and the above logic seems like it would need to be in the remainingCycles function somewhere (e.g. useOgcdCooldown) to actually use pots past the opener

Then most likely another sim is also broken since I took most of the pot logic from there

RhyTamok · 2024-12-18T23:15:46Z

This rotation is not ready to ship. Judging by the screenshot there are multiple major (and minor) issues that need to be addressed first.

Rotation is started with the wrong combo. Always needs to be Chaotic Spring combo first to apply Power Surge.
Every combo is broken. The respective second combo actions (Disembowel and Vorpal Thrust) are always replaced by a True Thrust. This also means that Power Surge is never accounted for.
Logic around double weaves needs to be adjusted. There should not be any double weaves with Stardiver
Logic for Life Surge has to be adjusted. Unless we're talking about the last 0.1% of optimization it should only be used on Heavens' Thrust and Drakesbane. It is used on Chaotic Spring in the opener here. It should also be held for burst windows and not necessarily used on cooldown
Geirskoguls 15% damage buff is not accounted for
Stardiver is used outside of Life at 42s
This isn't clear from the screenshot but Wyrmwind Thrust should also be held for buffs if possible (Always use before next Raiden, hold for any buffs applied before that)

The rotations for level 90 and 100 are virtually identical. You only gain 2 more follow-up skills and a replacement for the second combo skills, so as long as the double weave logic is sounds, it should be viable for both.
I am not sure how skillspeed is handled here but for speeds faster than 2.50 it becomes considerably more complex as you have to account for 9 GCD buff windows and delaying oGCD to not clip while still keeping optimal buff windows.

wolfcomp marked this pull request as ready for review October 24, 2024 17:20

wolfcomp changed the title ~~Add some extra sims~~ [DRG] LvL 90 Ultimate sim Oct 24, 2024

xpdota reviewed Oct 26, 2024

View reviewed changes

Comment thread packages/core/src/sims/melee/drg/drg_top_sim.ts Outdated

xpdota reviewed Oct 26, 2024

View reviewed changes

Comment thread packages/core/src/sims/melee/drg/drg_top_sim.ts Outdated

wolfcomp force-pushed the master branch from e4962cb to 3b2f952 Compare November 30, 2024 22:30

VioletHynes reviewed Dec 1, 2024

View reviewed changes

Comment thread packages/core/src/sims/melee/drg/drg_top_sim.ts Outdated

VioletHynes reviewed Dec 1, 2024

View reviewed changes

wolfcomp and others added 8 commits December 18, 2024 07:37

add drg top sim

b5c1a01

fix width size

857ccfb

fix some misstypes

0d3044c

rename sim name as both 90 ultimates share the same rotation

2b64b29

change supported levels

7cdfa3a

fix some lint warnings

e2b88d2

fix linting issues

9a30adc

rename some files

c8496b4

also fix merge conflicts

wolfcomp force-pushed the master branch from 3b2f952 to c8496b4 Compare December 18, 2024 06:46

wolfcomp requested review from VioletHynes and xpdota December 18, 2024 06:46

VioletHynes reviewed Dec 18, 2024

View reviewed changes

Uh oh!

Conversation

wolfcomp commented Oct 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Notes

Uh oh!

Uh oh!

Uh oh!

wolfcomp commented Oct 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wolfcomp commented Nov 30, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

VioletHynes Dec 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

RhyTamok commented Dec 18, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

wolfcomp commented Oct 11, 2024 •

edited

Loading

wolfcomp commented Oct 28, 2024 •

edited

Loading

VioletHynes Dec 1, 2024 •

edited

Loading