Refactor: ID should return a copy for TCP/UDPConn

core/adapter/adapter.go

@@ -6,19 +6,21 @@ import (
 	"gvisor.dev/gvisor/pkg/tcpip/stack"
 )
 
-// TCPConn implements the net.Conn interface.
+// TCPConn represents a TCP connection that implements net.Conn
+// and exposes its stack.TransportEndpointID.
 type TCPConn interface {
 	net.Conn
 
-	// ID returns the transport endpoint id of TCPConn.
-	ID() *stack.TransportEndpointID
+	// ID returns the transport endpoint id.
+	ID() stack.TransportEndpointID
 }
 
-// UDPConn implements net.Conn and net.PacketConn.
+// UDPConn represents a UDP connection that implements both net.Conn
+// and net.PacketConn and exposes its stack.TransportEndpointID.
 type UDPConn interface {
 	net.Conn
 	net.PacketConn
 
-	// ID returns the transport endpoint id of UDPConn.
-	ID() *stack.TransportEndpointID
+	// ID returns the transport endpoint id.
+	ID() stack.TransportEndpointID
 }

core/tcp.go

@@ -117,6 +117,6 @@ type tcpConn struct {
 	id stack.TransportEndpointID
 }
 
-func (c *tcpConn) ID() *stack.TransportEndpointID {
-	return &c.id
+func (c *tcpConn) ID() stack.TransportEndpointID {
+	return c.id
 }

core/udp.go

@@ -42,6 +42,6 @@ type udpConn struct {
 	id stack.TransportEndpointID
 }
 
-func (c *udpConn) ID() *stack.TransportEndpointID {
-	return &c.id
+func (c *udpConn) ID() stack.TransportEndpointID {
+	return c.id
 }