Improve on NEON path of no memmove#12
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #3 , the memmove bottleneck is completely solved now.
This PR improves code performance on no memmove path, and also does a refactoring. The
XJB_NO_MEMMOVE=0path is not affected (generates same assembly).According to my investigation, the design of the Apple Silicon load-store unit (LSU) results in little to no performance penalty for memmove operations; therefore this switch is disabled by default on Apple Silicon chips. The main optimizations in this PR are:
0x30302e30is not a valid immediate on AArch64, which causes the compiler to emit two additional instructions. Revert it to0x30303030and restore the original write order.memset(buf, '0', 8): reusing an existing vector register. Rewriting it explicitly asvst1q_s8((int8_t*)buf, vdupq_n_s8('0'))enables register reuse and removes a few instructions.Other refactoring: code reuse, removal of comments and unreachable code, and the addition of an
assumemacro. No actual logic changes were introduced.Performance on Apple M4: