Add embedded-xoodyak package - #10021
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new package definition for the embedded-xoodyak cryptographic library. The reviewer provided constructive feedback regarding the standardization of version strings by removing the 'v' prefix to improve compatibility with version comparison tools and recommended enhancing the installation script to support configurable build types, such as shared libraries.
midnight-wonderer
force-pushed
the
add/embedded-xoodyak
branch
from
May 20, 2026 07:24
9d831c5 to
d9d4e3d
Compare
Member
|
It fails on windows. |
Modify xmake.lua to conditionally include assembly files based on platform.
Added a patch for MSVC assembly during installation.
Fix MSVC assembly file inclusion and language settings.
Fix MSVC assembly file handling in xmake.lua.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, newbie here; can I publish the package?