bgfx: update to 9392 and support MD runtime - #10584
Open
FFFelian wants to merge 15 commits into
Open
Conversation
Removed specific patches for versions <=8752 and >=9392.
Contributor
Author
|
我看最新genie 1204已经可以处理vs2026了, 改成 |
luadebug
reviewed
Aug 7, 2026
Comment on lines
-80
to
+88
| os.trycp("../../win*_vs*/bin/*.lib|*example*", package:installdir("lib")) | ||
| os.trycp("../../win*_vs*/bin/*.dll", package:installdir("lib")) | ||
| os.trycp("../../win*_vs*/bin/*.lib", package:installdir("lib")) | ||
| os.trycp("../../win*_vs*/bin/*.exe", package:installdir("bin")) | ||
| os.trycp("../../*_vs*/bin/*.lib|*example*", package:installdir("lib")) | ||
| os.trycp("../../*_vs*/bin/*.dll", package:installdir("lib")) | ||
| os.trycp("../../*_vs*/bin/*.lib", package:installdir("lib")) | ||
| os.trycp("../../*_vs*/bin/*.exe", package:installdir("bin")) |
Member
There was a problem hiding this comment.
Is this going to work with old versions of bgfx?
Comment on lines
+124
to
+126
| if package:version() and package:version():ge("9392") and package:is_plat("iphoneos") then | ||
| io.replace("scripts/bgfx.lua", 'configuration { "osx*" }', 'configuration { "ios*" }\n\t\tbuildoptions { "-x objective-c++" }\n\tconfiguration { "osx*" }', {plain = true}) | ||
| end |
Member
There was a problem hiding this comment.
Try delete it maybe it would work without this, since we updated genie.
luadebug
reviewed
Aug 7, 2026
| end | ||
|
|
||
| add_deps("genie") | ||
| add_deps("genie 1204") |
Member
There was a problem hiding this comment.
I think we can keep it as is "genie" it should acquire newest?
luadebug
reviewed
Aug 7, 2026
| table.insert(configs, "/p:Platform=" .. (package:is_arch("x64") and "x64" or "Win32")) | ||
| table.insert(configs, "bgfx.sln") | ||
| table.insert(configs, "/p:Platform=" .. (package:is_arch("x64") and "x64" or (package:is_arch("arm64") and "ARM64" or (package:is_arch("arm") and "ARM" or "Win32")))) | ||
| table.insert(configs, tonumber(msvc:config("vs")) >= 2026 and "bgfx.slnx" or "bgfx.sln") |
Member
There was a problem hiding this comment.
Is it going to work with old versions of bgfx? As I'm not sure old ones provide .slnx
luadebug
reviewed
Aug 7, 2026
| envs.BIMG_DIR = bimgdir | ||
|
|
||
| if package:is_plat("windows") and package:is_arch("arm64") then | ||
| os.rm("3rdparty/glsl-optimizer/include/c99/stdint.h") |
Member
There was a problem hiding this comment.
Maybe it's better to place os.tryrm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
* update to 9392 and replace
bgfx::init()withbgfx::init(init)since the default argument was removed in 9392 .* add support to MD/MDd runtime by passing
--with-dynamic-runtime.