Skip to content

Conversation

@waruqi
Copy link
Member

@waruqi waruqi commented Dec 14, 2025

New version of onnx detected (package version: v1.18.0, last github version: v1.20.0)

@waruqi waruqi added the auto-update Automatic update label Dec 14, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @waruqi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the package definition for the ONNX library, incorporating the latest stable version v1.20.0. This change allows projects that depend on this package to leverage the most recent features, bug fixes, and performance improvements offered by the ONNX framework.

Highlights

  • ONNX Version Update: The ONNX library definition has been updated to include version v1.20.0.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is an automated update for the onnx package to version v1.20.0. The version update itself seems correct. However, I've raised a concern about an existing patch that has a broad version constraint (>=1.18.0). This patch will be applied to the new version 1.20.0 and may cause build failures if the fix is already included upstream. Please see the detailed comment.

add_urls("https://github.com/onnx/onnx/archive/refs/tags/$(version).tar.gz",
"https://github.com/onnx/onnx.git", {submodules = false})

add_versions("v1.20.0", "e9e9273cd39d460348aa3e2eb370a444b510e138c5f45dfa86ce50461901257b")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This change introduces v1.20.0, which falls under the version constraint '>=1.18.0' for the patch on line 19. It is likely that the patch from patches/1.18.0/cmake-abseil.patch is no longer needed for v1.20.0, as such fixes are often incorporated in newer upstream releases. Applying an obsolete patch can cause build failures. To prevent this, consider narrowing the patch's version constraint to only the versions for which it is known to be required, for instance '>=1.18.0, <1.20.0'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-update Automatic update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants