Skip to content

Conversation

@waruqi
Copy link
Member

@waruqi waruqi commented Dec 20, 2025

New version of pulsar detected (package version: 3.6.0, last github version: 4.0.0)

@waruqi waruqi added the auto-update Automatic update label Dec 20, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @waruqi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates the latest stable version of Apache Pulsar, 4.0.0, into the project's build configuration. This update ensures that the project can leverage the newest features, performance improvements, and bug fixes provided by the Pulsar client library, maintaining compatibility with the most current ecosystem.

Highlights

  • Pulsar Version Update: The xmake.lua configuration for the Pulsar package has been updated to include support for version 4.0.0, alongside existing versions, ensuring the build system can now utilize the latest release.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request automatically updates the pulsar package to version 4.0.0. The change itself is correct, but it misses updating the package's dependencies to match the new version's requirements. Specifically, Pulsar 4.0.0 requires newer versions of Boost and OpenSSL, among others. Without these updates, the package is likely to fail during build. I've added a comment with more details.


add_urls("https://github.com/apache/pulsar-client-cpp/archive/refs/tags/v$(version).tar.gz")

add_versions("4.0.0", "4bcb09558d1ced113a2c7e08c60b48ce3f0e9df1eaffac300697117bb1cadbe5")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

While adding the new version 4.0.0 is correct, its dependencies have not been updated. According to the Pulsar C++ client 4.0.0 release notes, this version has updated dependency requirements. For example:

  • It requires Boost 1.84.0, but the dependency on line 14 is still boost 1.81.0.
  • It requires OpenSSL 3.0.12, but the openssl package in this repository is on version 1.1.1.

These outdated dependencies will likely cause build failures. Please update the dependencies accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-update Automatic update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants