Skip to content

Conversation

@waruqi
Copy link
Member

@waruqi waruqi commented Dec 26, 2025

New version of fbgemm detected (package version: v1.2.0, last github version: v1.4.2)

@waruqi waruqi added the auto-update Automatic update label Dec 26, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @waruqi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on updating the fbgemm dependency to its latest stable version, v1.4.2. This update ensures the project benefits from the most recent features, bug fixes, and performance enhancements provided by the fbgemm library, maintaining compatibility and leveraging improvements in low-precision matrix multiplication.

Highlights

  • FBGEMM Package Update: The fbgemm package has been updated to version v1.4.2 by adding its version and corresponding commit hash to the xmake.lua configuration file.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is an automated update for the fbgemm package to version v1.4.2. The change correctly adds the new version to the xmake.lua package file. My review identifies a potential maintainability issue related to a broadly scoped patch that will be applied to this new version. While the change itself is simple, this associated risk should be considered to ensure future build stability.

add_urls("https://github.com/pytorch/FBGEMM/archive/refs/tags/$(version).tar.gz",
"https://github.com/pytorch/FBGEMM.git", {submodules = false})

add_versions("v1.4.2", "525abde5f161c1730952f175adfcbc77a4b7eeebd7b7a342170e9011734164cf")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While adding this new version is correct, it falls under the wide-ranged patch rule >=1.1.0 on line 16. This is a maintenance risk, as the patch might not be compatible with v1.4.2 since the CMakeLists.txt file it modifies could have changed. For better long-term maintenance and to avoid unexpected build failures, it's recommended to use more specific version constraints for patches. For example, the existing patch could be constrained to older versions (e.g., >=1.1.0, <=1.2.0), and a new, verified patch configuration could be added for v1.4.2 if it's still needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-update Automatic update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants