-
-
Notifications
You must be signed in to change notification settings - Fork 497
Auto-update fbgemm to v1.4.2 #8910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @waruqi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on updating the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request is an automated update for the fbgemm package to version v1.4.2. The change correctly adds the new version to the xmake.lua package file. My review identifies a potential maintainability issue related to a broadly scoped patch that will be applied to this new version. While the change itself is simple, this associated risk should be considered to ensure future build stability.
| add_urls("https://github.com/pytorch/FBGEMM/archive/refs/tags/$(version).tar.gz", | ||
| "https://github.com/pytorch/FBGEMM.git", {submodules = false}) | ||
|
|
||
| add_versions("v1.4.2", "525abde5f161c1730952f175adfcbc77a4b7eeebd7b7a342170e9011734164cf") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While adding this new version is correct, it falls under the wide-ranged patch rule >=1.1.0 on line 16. This is a maintenance risk, as the patch might not be compatible with v1.4.2 since the CMakeLists.txt file it modifies could have changed. For better long-term maintenance and to avoid unexpected build failures, it's recommended to use more specific version constraints for patches. For example, the existing patch could be constrained to older versions (e.g., >=1.1.0, <=1.2.0), and a new, verified patch configuration could be added for v1.4.2 if it's still needed.
New version of fbgemm detected (package version: v1.2.0, last github version: v1.4.2)