Skip to content

(C++ module support) improve jobgraph support #6373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

(C++ module support) improve jobgraph support #6373

wants to merge 1 commit into from

Conversation

Arthapz
Copy link
Member

@Arthapz Arthapz commented Apr 27, 2025

part 5 (and last) of #6336

@Arthapz Arthapz force-pushed the improve-jobgraph-support branch 5 times, most recently from 2d5b6c7 to e3de38e Compare April 27, 2025 17:09
@Arthapz Arthapz force-pushed the improve-jobgraph-support branch 2 times, most recently from a2e3d84 to 77bb2fd Compare April 29, 2025 14:46
@waruqi
Copy link
Member

waruqi commented Apr 29, 2025

What are the main improvements made in this patch?

@Arthapz
Copy link
Member Author

Arthapz commented Apr 29, 2025 •
edited
Loading

What are the main improvements made in this patch?

  • disable build.fence and enable full parallelization
  • support clang two phase compilation and add policy to toggle it build.c++.modules.two_phases
  • improve module build artifact reutilisation and introduce build.c++.modules.reuse.nocheck to force reutilisation without checking flags
  • modules from other targets now have includedirs flags from their original target when not reused (should partially fixes clang-scan-deps commandline misses target flags on command line  #6028 (comment)) (should be the same behavior as modules from packages)
  • fix --sdk= when using llvm toolchain on windows with msstl std module

@Arthapz Arthapz force-pushed the improve-jobgraph-support branch 4 times, most recently from 652e310 to 8d8cdbe Compare April 30, 2025 14:29
@Arthapz Arthapz force-pushed the improve-jobgraph-support branch from 8d8cdbe to 01864d3 Compare April 30, 2025 17:17
@Arthapz Arthapz force-pushed the improve-jobgraph-support branch from 01864d3 to 31dceaa Compare May 1, 2025 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waruqi waruqi waruqi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Arthapz @waruqi