add requires api checker#7584
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces new API checkers (api.requires.package and api.requires.configs) to validate package names and configurations in add_requires and add_requireconfs, along with corresponding tests and refactoring of package loading logic. The reviewer identified several issues, including a potential side-effect where table.join2 could mutate the project's internal state in-place, missing defensive checks for opt and requireinfo that could cause runtime errors, and an issue where requireconf is skipped entirely if its source information is missing.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
f498485 to
6dfa02b
Compare
8321b20 to
0c203f6
Compare
|
To minimize changes, I don't have time to review large patches. |
0c203f6 to
3d24d0b
Compare
3d24d0b to
de04689
Compare
|
I changed the implementation to minimize changes and added a checker only for This now also allows 我修改了实现方案,以尽量减少改动,并且仅为 现在, |
#7378
Adds checker for
add_requires()like discussed in #7394This does not check configs from package deps, e.g.:
will not be checked.