Skip to content

use FormatMessageW for Windows system error messages #7609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waruqi merged 3 commits into from
Jun 20, 2026
+16 −2
Merged

use FormatMessageW for Windows system error messages #7609

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ca9e48d
use FormatMessageW for Windows system error messages
choyy Jun 18, 2026
115e804
improve strerror fallback
choyy Jun 18, 2026
62fa217
strip trailing \r\n
choyy Jun 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions core/src/xmake/os/strerror.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,22 @@ tb_int_t xm_os_strerror(lua_State *lua) {
lua_pushstring(lua, strerr);
} else {
#if defined(TB_CONFIG_OS_WINDOWS) && !defined(TB_COMPILER_LIKE_UNIX)
tb_char_t strerr[128] = { 0 };
tb_snprintf(strerr, sizeof(strerr), "Unknown Error (%lu)", (tb_size_t)GetLastError());
DWORD error_code = GetLastError();
tb_char_t strerr[128 * 2] = { 0 };
tb_wchar_t wstrerr[128] = { 0 };
tb_size_t len = 0;
if (FormatMessageW(FORMAT_MESSAGE_FROM_SYSTEM | FORMAT_MESSAGE_IGNORE_INSERTS,
NULL, error_code, MAKELANGID(LANG_NEUTRAL, SUBLANG_DEFAULT),
wstrerr, tb_arrayn(wstrerr), NULL) &&
(len = tb_wcslen(wstrerr)) > 0) {
while (len > 0 && (wstrerr[len - 1] == L'\r' || wstrerr[len - 1] == L'\n')) {
wstrerr[--len] = L'\0';
}
WideCharToMultiByte(CP_UTF8, 0, wstrerr, -1, strerr, sizeof(strerr), tb_null, tb_null);
}
if (strerr[0] == '\0') {
tb_snprintf(strerr, sizeof(strerr), "Unknown Error (%lu)", (tb_size_t)error_code);
}
lua_pushstring(lua, strerr);
Comment thread
choyy marked this conversation as resolved.
#else
lua_pushstring(lua, strerror(errno));
Expand Down
Loading