Remove unused include file #22
Open
+849
−113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was causing a conflict with a project that had its own print.h header file.
Adds long formatting case for use in FreeRTOS+TCP, which uses %l for 32 bit unsigned values.
Replaced the debug_printf function with one derived from the one Xilinx uses with their standalone BSP. Also added debug_sprintf and debug_snprintf functions. All three call the same underlying function.
mbanth
requested changes
Nov 25, 2020
Contributor
mbanth
left a comment
mbanth
left a comment
There was a problem hiding this comment.
Looks like a substantial and beneficial enhancement to logging functionality. It deserves further review. A copyright date range has become stale. Otherwise I did not identify any changes needed during my very cursory review.
| @@ -1,140 +1,480 @@ | |||
| // Copyright (c) 2014-2016, XMOS Ltd, All rights reserved | |||
| // Copyright (c) 2014-2019, XMOS Ltd, All rights reserved | |||
Contributor
There was a problem hiding this comment.
Copyright date range needs updated to 2014-2020.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the two #include <print.h> lines in debug_printf.c.
This was causing a conflict with a project that had its own print.h
header file, and nothing in print.h is used anyway.