Add support for libraries specifying linker options for the application in LIB_COMPILER_FLAGS.#215
Open
shuchitak wants to merge 1 commit into
Open
Add support for libraries specifying linker options for the application in LIB_COMPILER_FLAGS.#215shuchitak wants to merge 1 commit into
shuchitak wants to merge 1 commit into
Conversation
xross
reviewed
Feb 27, 2026
xross
left a comment
xross
left a comment
Collaborator
There was a problem hiding this comment.
Useful addition :) can we add to the API docs?
shuchitak
force-pushed
the
lib_linker_flags
branch
from
February 27, 2026 17:01
f9cd209 to
ae211e5
Compare
Author
oops, forgot about documentation. Will do. |
shuchitak
force-pushed
the
lib_linker_flags
branch
4 times, most recently
from
February 27, 2026 20:21
f5c7f72 to
cac246e
Compare
…on in LIB_COMPILER_FLAGS. Note that specifying LIB_COMPILER_FLAGS is only supported for libraries registered as XMOS_REGISTER_MODULE() and not for static libraries that are registered as XMOS_REGISTER_STATIC_LIB()
shuchitak
force-pushed
the
lib_linker_flags
branch
from
February 27, 2026 20:42
cac246e to
72254a3
Compare
Collaborator
|
isn't the comment here and the commit comment incorrect? It says LIB_COMPILER_FLAGS but should be LIB_LINKER_FLAGS? |
Collaborator
|
I think a good test to add would be two links specifying the same flag i.e. a clash. This may need handling. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that specifying LIB_COMPILER_FLAGS is only supported for libraries registered as XMOS_REGISTER_MODULE() and not for static libraries that are registered as XMOS_REGISTER_STATIC_LIB()